Bug 1336166 (golang-github-technoweenie-assert)
| Summary: | Review Request: golang-github-technoweenie-assert - Asserts to Go testomg | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Jan Chaloupka <jchaloup> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jchaloup, package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | jchaloup:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-19 10:02:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Igor Gnatenko
2016-05-15 01:45:38 UTC
Does not make much sense to package this. It is a fork https://github.com/bmizerany/assert. https://github.com/technoweenie/assert does not provide any new functionality. I would recommend to change all imports prefixed with github.com/technoweenie/assert to be prefixed with github.com/bmizerany/assert. The bmizerany repo has a note that it's unmaintained and the Go testing package should be used instead. I don't know what that means for the technoweenie fork. It appears to me that git-lfs is using https://github.com/stretchr/testify now, so this package might not be needed. There appears to be no need for this now? |