Bug 1336166 (golang-github-technoweenie-assert) - Review Request: golang-github-technoweenie-assert - Asserts to Go testomg
Summary: Review Request: golang-github-technoweenie-assert - Asserts to Go testomg
Keywords:
Status: CLOSED WONTFIX
Alias: golang-github-technoweenie-assert
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-15 01:45 UTC by Igor Gnatenko
Modified: 2017-11-19 10:02 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-11-19 10:02:38 UTC
Type: ---
Embargoed:
jchaloup: fedora-review?


Attachments (Terms of Use)

Description Igor Gnatenko 2016-05-15 01:45:38 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/golang-github-technoweenie-assert.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/golang-github-technoweenie-assert-0-0.1.gitb25ea30.fc25.src.rpm
Description: Asserts to Go testing.
Fedora Account System Username: ignatenkobrain

Comment 1 Jan Chaloupka 2016-07-11 09:46:16 UTC
Does not make much sense to package this. It is a fork https://github.com/bmizerany/assert. https://github.com/technoweenie/assert does not provide any new functionality. I would recommend to change all imports prefixed with github.com/technoweenie/assert to be prefixed with github.com/bmizerany/assert.

Comment 2 Elliott Sales de Andrade 2017-02-12 06:16:50 UTC
The bmizerany repo has a note that it's unmaintained and the Go testing package should be used instead. I don't know what that means for the technoweenie fork.

It appears to me that git-lfs is using https://github.com/stretchr/testify now, so this package might not be needed.

Comment 3 Elliott Sales de Andrade 2017-11-18 23:36:31 UTC
There appears to be no need for this now?


Note You need to log in before you can comment on or make changes to this bug.