Bug 1336720

Summary:	virsh domdisplay not working when spice listens on a unix socket
Product:	[Community] Virtualization Tools	Reporter:	Christophe Fergeau <cfergeau>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	fjin, jcfaracco, jdenemar, rbalakri
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-16 07:13:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christophe Fergeau 2016-05-17 10:08:37 UTC

After this series https://www.redhat.com/archives/libvir-list/2016-May/msg00404.html adding <listen type="unix" socket="/some/path/foo.sock"/> support to spice graphics node, virsh domdisplay should be taught about this as well so that it returns spice+unix:///some/path/foo.sock

Comment 1 Christophe Fergeau 2017-06-29 13:10:03 UTC

*** Bug 1466334 has been marked as a duplicate of this bug. ***

Comment 2 Julio Faracco 2017-10-15 15:13:48 UTC

It was fixed by:

commit 215b3ab4ef8b43b5ab0318f9c8c56e549c2fa340
Author:     Julio Faracco <jcfaracco>
AuthorDate: Fri Jul 28 18:49:35 2017 -0300
Commit:     Michal Privoznik <mprivozn>
CommitDate: Wed Aug 2 10:03:23 2017 +0200

    tools: virsh: Adding unix socket support to 'domdisplay' command.
    
    This commit adds the unix socket URL support to 'domdisplay' command.
    Before, even if an user was using unix socket to define a spice graphics,
    the command 'domdisplay' showed that the settings were not supported. Now,
    the command shows the proper URL: spice+unix://foo/bar.sock.
    
    Settings:
    <graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1'>
      <listen type='address' address='127.0.0.1'/>
    </graphics>
    <graphics type='spice'>
      <listen type='socket' socket='/tmp/spice.sock'/>
    </graphics>
    
    Before:
    virsh # domdisplay --all Windows7
    vnc://127.0.0.1:0
    
    After:
    virsh # domdisplay --all Windows7
    vnc://127.0.0.1:0
    spice+unix:///tmp/spice.sock