Bug 1337300

Summary:	file completion doesn't work for libreswan import
Product:	Red Hat Enterprise Linux 7	Reporter:	Vladimir Benes <vbenes>
Component:	NetworkManager	Assignee:	Rashid Khan <rkhan>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.3	CC:	atragler, bgalvani, fgiudici, lrintel, rkhan, thaller
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	NetworkManager-1.4.0-0.1.git20160606.b769b4df.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-03 19:10:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vladimir Benes 2016-05-18 18:35:23 UTC

Description of problem:
when i hit tab after 'nmcli connection import type libreswan file' it does nothing. It should show files.

Version-Release number of selected component (if applicable):
NetworkManager-1.2.0-1.el7.x86_64

Comment 1 Rashid Khan 2016-05-18 21:54:58 UTC

Setting to LOW LOW if tab completion is the only problem.

If you cannot see the files at all, then please feel free to raise the priority

Comment 2 Vladimir Benes 2016-05-19 08:53:45 UTC

I cannot see the files when hitting tab. I have to remember in which file the vpn conf is actually in. This always leads to deleting the command running ls and executing it again.

Comment 3 Thomas Haller 2016-05-19 09:32:18 UTC

I hijacked this BZ for additional issues that I found.
Fixed bash-completion + other related fixes here:

please review: th/cli-vpn-import-fixes-rh1337300

Comment 4 Beniamino Galvani 2016-05-19 09:47:59 UTC

(In reply to Thomas Haller from comment #3)
> please review: th/cli-vpn-import-fixes-rh1337300

LGTM

Comment 5 Francesco Giudici 2016-05-19 10:54:43 UTC

lgtm

Comment 6 Thomas Haller 2016-05-19 14:22:38 UTC

merged upstream:


master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=3d25b2e1a1eb4377d202055e901b51bfb0415f56

nm-1-2: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2c34cd9ab578f488f7d15eed7db3fafd07df17a7
and https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1b815346aa39785911d6ddf5c9860731fa9b3436

Comment 9 errata-xmlrpc 2016-11-03 19:10:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2581.html