Bug 1337300 – file completion doesn't work for libreswan import

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1337300 - file completion doesn't work for libreswan import

Summary:	file completion doesn't work for libreswan import

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	NetworkManager (Show other bugs)
Sub Component:
Version:	7.3
Hardware:	Unspecified Unspecified

Priority	low Severity low
Target Milestone:	rc
Target Release:	---
Assigned To:	Rashid Khan
QA Contact:	Desktop QE
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-05-18 14:35 EDT by Vladimir Benes
Modified:	2016-11-03 15:10 EDT (History)
CC List:	6 users (show)

See Also:
Fixed In Version:	NetworkManager-1.4.0-0.1.git20160606.b769b4df.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-11-03 15:10:23 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2016:2581	normal	SHIPPED_LIVE	Low: NetworkManager security, bug fix, and enhancement update	2016-11-03 08:08:07 EDT

Groups: None (edit)

Description Vladimir Benes 2016-05-18 14:35:23 EDT

Description of problem:
when i hit tab after 'nmcli connection import type libreswan file' it does nothing. It should show files.

Version-Release number of selected component (if applicable):
NetworkManager-1.2.0-1.el7.x86_64

Comment 1 Rashid Khan 2016-05-18 17:54:58 EDT

Setting to LOW LOW if tab completion is the only problem.

If you cannot see the files at all, then please feel free to raise the priority

Comment 2 Vladimir Benes 2016-05-19 04:53:45 EDT

I cannot see the files when hitting tab. I have to remember in which file the vpn conf is actually in. This always leads to deleting the command running ls and executing it again.

Comment 3 Thomas Haller 2016-05-19 05:32:18 EDT

I hijacked this BZ for additional issues that I found.
Fixed bash-completion + other related fixes here:

please review: th/cli-vpn-import-fixes-rh1337300

Comment 4 Beniamino Galvani 2016-05-19 05:47:59 EDT

(In reply to Thomas Haller from comment #3)
> please review: th/cli-vpn-import-fixes-rh1337300

LGTM

Comment 5 Francesco Giudici 2016-05-19 06:54:43 EDT

lgtm

Comment 6 Thomas Haller 2016-05-19 10:22:38 EDT

merged upstream:


master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=3d25b2e1a1eb4377d202055e901b51bfb0415f56

nm-1-2: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2c34cd9ab578f488f7d15eed7db3fafd07df17a7
and https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1b815346aa39785911d6ddf5c9860731fa9b3436

Comment 9 errata-xmlrpc 2016-11-03 15:10:23 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2581.html

Note You need to log in before you can comment on or make changes to this bug.