Bug 1337310

Summary: VMware VM Reconfigure Add Disk fails when a new SCSI controller is needed
Product: Red Hat CloudForms Management Engine Reporter: Adam Grare <agrare>
Component: ProvidersAssignee: Adam Grare <agrare>
Status: CLOSED CURRENTRELEASE QA Contact: luke couzens <lcouzens>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.6.0CC: cpelland, dbomhof, gekis, jfrey, jhardy, nachandr, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: reconfigure:vmware
Fixed In Version: 5.7.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1346037 1358488 (view as bug list) Environment:
Last Closed: 2017-01-11 20:20:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1346037, 1358488    

Description Adam Grare 2016-05-18 19:25:00 UTC
Description of problem:
Adding a new disk that will also need a new SCSI controller the VM Reconfigure Task fails with error "Invalid configuration for device '1'"

Version-Release number of selected component (if applicable):
5.6.0.6 beta

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with 15 disks
2. Add a new disk with CloudForms using the VM Reconfigure dialog

Actual results:
The task will fail with "Invalid configuration for device '1'"

Expected results:
The new disk as well as a new SCSI controller are added to the VM

Additional info:
The code to add a new SCSI controller when needed always puts the controller on bus 0.  This will work if there are no SCSI controllers on the VM, but if additional controllers need to be added the next available bus number has to be used.

Comment 2 Adam Grare 2016-06-03 13:37:53 UTC
https://github.com/ManageIQ/manageiq/pull/8899

Comment 6 luke couzens 2016-09-16 12:51:44 UTC
Verified in 5.7.0.0