Bug 1337812
| Summary: | ability to modify lab controllers from CLI | ||
|---|---|---|---|
| Product: | [Retired] Beaker | Reporter: | matt jia <mjia> |
| Component: | command line | Assignee: | matt jia <mjia> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | tools-bugs <tools-bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | low | ||
| Version: | 22 | CC: | dcallagh, dowang, ebaak, mjia, rjoost, tools-bugs |
| Target Milestone: | 23.0 | Keywords: | FutureFeature, Patch, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1211119 | Environment: | |
| Last Closed: | 2016-07-07 23:12:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1211119, 1251355 | ||
| Bug Blocks: | |||
|
Description
matt jia
2016-05-20 06:46:44 UTC
Currently, the HTTP API for updating existing lab controllers is not validated properly on updating fqdn. We should use the same validation in updating systems. (In reply to matt jia from comment #1) > Currently, the HTTP API for updating existing lab controllers is not > validated properly on updating fqdn. We should use the same validation in > updating systems. Here is a patch to fix this issue: https://gerrit.beaker-project.org/#/c/4905/ (In reply to matt jia from comment #2) > (In reply to matt jia from comment #1) > > Currently, the HTTP API for updating existing lab controllers is not > > validated properly on updating fqdn. Reword the sentence to make it clear: Currently, the HTTP API for updating existing lab controllers is not validating FQDN properly. validate that lab controller FQDN is valid https://gerrit.beaker-project.org/#/c/4905 use sqlalchemy validator for users' display name and email address https://gerrit.beaker-project.org/#/c/4922 bkr labcontroller-modify: CLI for modifying a lab conroller https://gerrit.beaker-project.org/#/c/4924 Dear Matt, we've spoken to the labs guys today. Would you mind adding the ability to disable the lab controller to the CLI while you're at it? Reason being is to be able to disable the lab controller in cases of problems. This bug fix is included in beaker-client-23.0-0.git.244.0980974 which is currently available for download here: https://beaker-project.org/nightlies/develop/ Beaker 23.0 has been released. |