Bug 1338544

Summary: fuse: In fuse_first_lookup(), dict is not un-referenced in case create_frame returns an empty pointer.
Product: [Community] GlusterFS Reporter: Olia Kremmyda <olympia.kremmyda>
Component: fuseAssignee: Olia Kremmyda <olympia.kremmyda>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.9.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1339137 1339138 (view as bug list) Environment:
Last Closed: 2017-03-27 18:11:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1339137, 1339138    

Description Olia Kremmyda 2016-05-22 15:59:43 UTC
Description of problem:
In fuse_first_lookup function, "dict_unref (dict)" should be included in the out label, in case create_frame returns an empty pointer the dict to be unreferenced as well.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-05-22 18:07:02 UTC
REVIEW: http://review.gluster.org/14463 (fuse: In fuse_first_lookup(), dict is not un-referenced in case create_frame returns an empty pointer.) posted (#1) for review on release-3.7 by Olia Kremmyda (olympia.kremmyda)

Comment 2 Vijay Bellur 2016-05-22 18:42:37 UTC
REVIEW: http://review.gluster.org/14464 (fuse: In fuse_first_lookup(), dict is not un-referenced in case create_frame returns an empty pointer.) posted (#1) for review on master by Olia Kremmyda (olympia.kremmyda)

Comment 3 Vijay Bellur 2016-05-22 18:44:56 UTC
REVIEW: http://review.gluster.org/14464 (fuse: In fuse_first_lookup(), dict is not un-referenced in case create_frame returns an empty pointer.) posted (#2) for review on master by Olia Kremmyda (olympia.kremmyda)

Comment 4 Vijay Bellur 2016-05-22 20:39:48 UTC
REVIEW: http://review.gluster.org/14465 (fuse: In fuse_first_lookup(), dict is not un-referenced in case create_frame returns an empty pointer.) posted (#1) for review on release-3.8 by Olia Kremmyda (olympia.kremmyda)

Comment 5 Vijay Bellur 2016-05-23 13:31:23 UTC
REVIEW: http://review.gluster.org/14464 (fuse: unref dict even if fuse_first_lookup fails) posted (#3) for review on master by Jeff Darcy (jdarcy)

Comment 6 Vijay Bellur 2016-05-23 13:33:58 UTC
COMMIT: http://review.gluster.org/14464 committed in master by Jeff Darcy (jdarcy) 
------
commit b01fb8d3bb9772d94073aaa52b2d8210ac4fabb8
Author: Kremmyda, Olia (NSN - GR/Athens) <olympia.kremmyda>
Date:   Sun May 22 21:40:19 2016 +0300

    fuse: unref dict even if fuse_first_lookup fails
    
    In fuse_first_lookup function, "dict_unref (dict)" should be included in
    the out label, in case create_frame returns an empty pointer the dict to
    be unreferenced as well.
    
    
    Bug: 1338544
    Change-Id: Ifb8a3378aec6521c1aa848f818968b6bfdb72089
    Signed-off-by: Olia Kremmyda <olympia.kremmyda>
    Reviewed-on: http://review.gluster.org/14464
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Tested-by: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 7 Shyamsundar 2017-03-27 18:11:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/