Bug 1338813

Summary: Some tests in hammer-cli-katello use MiniTest's assert() method improperly
Product: Red Hat Satellite Reporter: Andrew Kofink <akofink>
Component: HammerAssignee: Andrew Kofink <akofink>
Status: CLOSED ERRATA QA Contact: David Davis <daviddavis>
Severity: medium Docs Contact:
Priority: unspecified    
Version: UnspecifiedCC: bbuckingham, cwelton, daviddavis, mmccune
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/15142
Whiteboard:
Fixed In Version: rubygem-hammer_cli_katello-0.0.22.14-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-27 11:11:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andrew Kofink 2016-05-23 13:17:31 UTC 
Description of problem:
The assert() method is improperly used in several locations, causing tests to pass when they should potentially fail.

Version-Release number of selected component (if applicable):
upstream

How reproducible:
always

Steps to Reproduce:
N/A

Actual results:
N/A

Expected results:
N/A

Additional info:
Most of these tests use assert() like assert_equal(x, y), where the assertion is dependent on the equality of x and y. The assert(x, msg) method asserts that x is a true value, and provides msg when the assertion fails.
Comment 1 Andrew Kofink 2016-05-23 13:18:05 UTC 
Created redmine issue http://projects.theforeman.org/issues/15142 from this bug
Comment 2 Bryan Kearney 2016-06-02 20:16:34 UTC 
Moving to POST since upstream bug http://projects.theforeman.org/issues/15142 has been closed
Comment 3 Corey Welton 2016-06-03 15:15:29 UTC 
QE notes:  dev task, nothing to test here.
Comment 5 David Davis 2016-06-30 18:48:06 UTC 
Nothing to test. Setting to verified.
Comment 6 Bryan Kearney 2016-07-27 11:11:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1501