Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1338813 - Some tests in hammer-cli-katello use MiniTest's assert() method improperly
Summary: Some tests in hammer-cli-katello use MiniTest's assert() method improperly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Hammer
Version: Unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Andrew Kofink
QA Contact: David Davis
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-23 13:17 UTC by Andrew Kofink
Modified: 2019-09-25 20:54 UTC (History)
4 users (show)

Fixed In Version: rubygem-hammer_cli_katello-0.0.22.14-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-27 11:11:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 15142 0 None None None 2016-05-23 14:05:45 UTC

Description Andrew Kofink 2016-05-23 13:17:31 UTC
Description of problem:
The assert() method is improperly used in several locations, causing tests to pass when they should potentially fail.

Version-Release number of selected component (if applicable):
upstream

How reproducible:
always

Steps to Reproduce:
N/A

Actual results:
N/A

Expected results:
N/A

Additional info:
Most of these tests use assert() like assert_equal(x, y), where the assertion is dependent on the equality of x and y. The assert(x, msg) method asserts that x is a true value, and provides msg when the assertion fails.

Comment 1 Andrew Kofink 2016-05-23 13:18:05 UTC
Created redmine issue http://projects.theforeman.org/issues/15142 from this bug

Comment 2 Bryan Kearney 2016-06-02 20:16:34 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/15142 has been closed

Comment 3 Corey Welton 2016-06-03 15:15:29 UTC
QE notes:  dev task, nothing to test here.

Comment 5 David Davis 2016-06-30 18:48:06 UTC
Nothing to test. Setting to verified.

Comment 6 Bryan Kearney 2016-07-27 11:11:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1501


Note You need to log in before you can comment on or make changes to this bug.