Bug 1339658

Summary:	OvfManager is not tested for disks info consistency in import/export
Product:	[oVirt] ovirt-engine	Reporter:	Tal Nisan <tnisan>
Component:	BLL.Storage	Assignee:	Tal Nisan <tnisan>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Aharon Canan <acanan>
Severity:	medium	Docs Contact:
Priority:	high
Version:	4.0.0	CC:	acanan, amureini, bugs, tnisan
Target Milestone:	ovirt-4.0.0-rc	Keywords:	CodeChange
Target Release:	4.0.0	Flags:	rule-engine: ovirt-4.0.0+ rule-engine: planning_ack+ tnisan: devel_ack+ rule-engine: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-01 12:28:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tal Nisan 2016-05-25 14:24:22 UTC

Description of problem:
While a test for OvfManager exist it checks only the export/import of the VM and all its properties and the network interfaces, the disks export/import is not tested.
Since this class is the main point for import and export operation and on top of that all snapshot related operations it is crucial that the disks info consistency will be tested as well.

Comment 1 Aharon Canan 2016-07-10 14:44:26 UTC

Do we have a way to verify this one?
Is it code change so only regression?

Comment 2 Tal Nisan 2016-07-10 15:53:42 UTC

Nothing to test here on your side, the logic itself hasn't changed, only some unit tests were added

Comment 3 Carlos Mestre González 2016-07-11 10:17:34 UTC

Tal: Seems I shouldn't be assigned as qa to this, only the person writing/verifying the unit tests.

Comment 4 Allon Mureinik 2016-07-11 12:14:39 UTC

This is CodeChange BZ. I verified the tests were written and merged, and Jenkin's CI verifies they pass.
Setting as VERIFIED.