Bug 1339658 - OvfManager is not tested for disks info consistency in import/export
Summary: OvfManager is not tested for disks info consistency in import/export
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.0.0-rc
: 4.0.0
Assignee: Tal Nisan
QA Contact: Aharon Canan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-25 14:24 UTC by Tal Nisan
Modified: 2016-08-01 12:28 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-08-01 12:28:23 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
tnisan: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 57851 0 master MERGED core: Add tests to OvfManagerTest 2016-05-25 17:52:17 UTC
oVirt gerrit 58062 0 master MERGED core: Add a method to generate random MAC addresses to RandomUtils 2016-05-25 17:52:10 UTC
oVirt gerrit 58072 0 ovirt-engine-4.0 MERGED core: Add a method to generate random MAC addresses to RandomUtils 2016-05-25 17:54:56 UTC
oVirt gerrit 58073 0 ovirt-engine-4.0 MERGED core: Add tests to OvfManagerTest 2016-05-25 17:54:45 UTC

Description Tal Nisan 2016-05-25 14:24:22 UTC 
Description of problem:
While a test for OvfManager exist it checks only the export/import of the VM and all its properties and the network interfaces, the disks export/import is not tested.
Since this class is the main point for import and export operation and on top of that all snapshot related operations it is crucial that the disks info consistency will be tested as well.
Comment 1 Aharon Canan 2016-07-10 14:44:26 UTC 
Do we have a way to verify this one?
Is it code change so only regression?
Comment 2 Tal Nisan 2016-07-10 15:53:42 UTC 
Nothing to test here on your side, the logic itself hasn't changed, only some unit tests were added
Comment 3 Carlos Mestre González 2016-07-11 10:17:34 UTC 
Tal: Seems I shouldn't be assigned as qa to this, only the person writing/verifying the unit tests.
Comment 4 Allon Mureinik 2016-07-11 12:14:39 UTC 
This is CodeChange BZ. I verified the tests were written and merged, and Jenkin's CI verifies they pass.
Setting as VERIFIED.
Note You need to log in before you can comment on or make changes to this bug.