Bug 1339760
| Summary: | Review Request: js-gl-matrix - Javascript module designed to perform vector and matrix operations very fast | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mairi Dulaney <jdulaney> |
| Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ignatenko, package-review |
| Target Milestone: | --- | Flags: | ignatenko:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-18 04:25:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mairi Dulaney
2016-05-25 19:22:43 UTC
Scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=14250866 Spec URL: https://jdulaney.fedorapeople.org/js-glmatrix.spec SRPM URL: https://jdulaney.fedorapeople.org/js-glmatrix-2.3.2-2.fc24.src.rpm > Requires: web-assets-filesystem add this req. > %{installdir}/%{version} not sure if it should be versioned. What do you think? Also according to guidelines name should be the same as in upstream (gl-matrix). I think you should rename stuff into js-gl-matrix Spec URL: https://jdulaney.fedorapeople.org/js-gl-matrix.spec SRPM URL: https://jdulaney.fedorapeople.org/js-gl-matrix-2.3.2-3.fc24.src.rpm The versioning is similar to how other js packages are done. I figure it's a good thing so it's easy to install multiple versions if desired. When I was talking about name - %global installdir %{buildroot}%{_jsdir}/glmatrix I was also talking to change installdir ;)
Also I would do: %global modname gl-matrix
and use %modname to replace that word
Spec URL: https://jdulaney.fedorapeople.org/js-gl-matrix.spec SRPM URL: https://jdulaney.fedorapeople.org/js-gl-matrix-2.3.2-4.fc24.src.rpm Fixed the install dir. I don't like to use variables for things like that as a personal preference. If you really want me to, I can do that, but I prefer not to. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/js-gl-matrix js-gl-matrix-2.3.2-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d43d1f0e js-gl-matrix-2.3.2-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-eac799b2a0 js-gl-matrix-2.3.2-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d43d1f0e js-gl-matrix-2.3.2-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-eac799b2a0 js-gl-matrix-2.3.2-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. js-gl-matrix-2.3.2-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |