Bug 1339760 - Review Request: js-gl-matrix - Javascript module designed to perform vector and matrix operations very fast
Summary: Review Request: js-gl-matrix - Javascript module designed to perform vector a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-05-25 19:22 UTC by Mairi Dulaney
Modified: 2016-06-18 18:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-18 04:25:01 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)

Description Mairi Dulaney 2016-05-25 19:22:43 UTC
Spec URL: https://jdulaney.fedorapeople.org/glmatrix.spec
SRPM URL: https://jdulaney.fedorapeople.org/glmatrix-2.3.2-1.fc24.src.rpm
Description: Designed to perform vector and matrix operations stupidly fast
Fedora Account System Username:  jdulaney

Comment 1 Mairi Dulaney 2016-05-25 19:23:04 UTC
Scratch build here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=14250866

Comment 3 Igor Gnatenko 2016-06-04 06:52:07 UTC
> Requires:  web-assets-filesystem
add this req.

> %{installdir}/%{version}
not sure if it should be versioned. What do you think?

Also according to guidelines name should be the same as in upstream (gl-matrix). I think you should rename stuff into js-gl-matrix

Comment 4 Mairi Dulaney 2016-06-04 20:43:45 UTC
Spec URL: https://jdulaney.fedorapeople.org/js-gl-matrix.spec
SRPM URL: https://jdulaney.fedorapeople.org/js-gl-matrix-2.3.2-3.fc24.src.rpm

The versioning is similar to how other js packages are done.  I figure it's a good thing so it's easy to install multiple versions if desired.

Comment 5 Igor Gnatenko 2016-06-05 07:29:54 UTC
When I was talking about name - %global installdir %{buildroot}%{_jsdir}/glmatrix I was also talking to change installdir ;)

Also I would do: %global modname gl-matrix
and use %modname to replace that word

Comment 6 Mairi Dulaney 2016-06-06 01:58:13 UTC
Spec URL: https://jdulaney.fedorapeople.org/js-gl-matrix.spec
SRPM URL: https://jdulaney.fedorapeople.org/js-gl-matrix-2.3.2-4.fc24.src.rpm

Fixed the install dir.  I don't like to use variables for things like that as a personal preference.  If you really want me to, I can do that, but I prefer not to.

Comment 7 Gwyn Ciesla 2016-06-07 19:02:55 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/js-gl-matrix

Comment 8 Fedora Update System 2016-06-08 14:15:26 UTC
js-gl-matrix-2.3.2-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d43d1f0e

Comment 9 Fedora Update System 2016-06-08 14:15:58 UTC
js-gl-matrix-2.3.2-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-eac799b2a0

Comment 10 Fedora Update System 2016-06-08 17:54:34 UTC
js-gl-matrix-2.3.2-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d43d1f0e

Comment 11 Fedora Update System 2016-06-09 04:50:58 UTC
js-gl-matrix-2.3.2-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-eac799b2a0

Comment 12 Fedora Update System 2016-06-18 04:24:59 UTC
js-gl-matrix-2.3.2-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-06-18 18:37:38 UTC
js-gl-matrix-2.3.2-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.