Bug 1341564

Summary: virt-p2v spinner should be hidden when it stops spinning
Product: Red Hat Enterprise Linux 7 Reporter: keanli <keanli>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 7.3CC: juzhou, mxie, mzhan, ptoscano, tzheng, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: P2V
Fixed In Version: libguestfs-1.32.5-5.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-03 18:00:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
virt-p2v_client none

Description keanli 2016-06-01 09:59:35 UTC
Created attachment 1163566 [details]
virt-p2v_client

Description of problem:
The load icon is always visible after finished the test connection  

Version-Release number of selected component (if applicable):
virt-p2v-1.32.4-1.el7.iso


How reproducible:
100%

Steps to Reproduce:
1.Boot the source machine into p2v client via iso
2.Input correct ip and root password, them click the "Test Connection " button 
3.The load icon still visible after finished the test connection.please check the screenshot in attachment 

Actual results:
As above description

Expected results:
For the load icon, I think the purpose is talk about customer the program is working for the current operation.So for improve UX, suggestion after finished load remove the load icon to invisible instead of static load icon.
 
Additional info:

Comment 3 keanli 2016-06-15 05:39:34 UTC
I can reproduce it with build:
virt-p2v-1.32.4-1.el7.iso

Verify it with build:
virt-p2v-1.32.5-2.el7.iso

Scenario 1:input correct conversion server ip with root's password on virt-p2v client
Steps:
1.1 Boot the source machine into p2v client via iso
1.2 Input correct conversion server ip with correct root's password, then click the "Test Connection " button
1.3 Check the spinner whether or not auto hidden when it stops spinning
Test result: Virt-p2v spinner auto hidden when it stops spinning,the "next" button is available

Scenario 2: input correct conversion server ip with incorrect root's password on virt-p2v client
Steps:
2.1 Boot the source machine into p2v client via iso
2.2 Input correct conversion server ip with incorrect root's password, then click the "Test Connection " button
2.3 Check the spinner whether or not auto hidden when it stops spinning
Test result:Virt-p2v spinner auto hidden when it stops spinning, the "next" button is unavailable

Verify Result:As above verify result,virt-p2v spinner can hidden when it stops spinning.The bug has been fixed , so move it to VERIFIED

Comment 4 Richard W.M. Jones 2016-06-17 20:18:01 UTC
Actually, a further commit is needed to fully fix this:

https://github.com/libguestfs/libguestfs/commit/e6a173d5d4f2fc59dee96d022fe3fc59339a046c

(Try pressing the 'Test Connection' button as soon as the
virt-p2v dialog opens, when the Server field is empty)

Comment 6 zhoujunqin 2016-06-22 08:19:12 UTC
I can reproduce this issue with build:
virt-p2v-1.32.4-3.el7.iso

Then try to verify this bug with new build:
virt-p2v-1.32.5-5.el7.iso

Steps:
Scenario 1: correct ip + correct user's password
Steps:
1.1 Boot the source machine into p2v client via iso
1.2 Input correct conversion server ip with correct root's password, then click the "Test Connection " button
1.3 Check the spinner status when stops spinning

Result: 
Virt-p2v spinner auto hidden when it stops spinning, you can see following information:
Connected to the conversion server.
Press the "Next" button to configure the conversion process.
and Next button is enable.

Scenario 2: correct ip + incorrect user's password
Steps:
2.1 Boot the source machine into p2v client via iso
2.2 Input correct conversion server ip with incorrect root's password, then click the "Test Connection " button
2.3 Check the spinner status when stops spinning

Result: 
Virt-p2v spinner auto hidden when it stops spinning, you can see following information:
unexpected password prompt:probably
the password supplied is wrong
And "Next" button is grey(disabled).

Scenario 3: Press 'Test Connection' button as soon as the virt-p2v dialog opens, when the Server field is empty.
3.1 Boot the source machine into p2v client via iso
3.2 When virt-p2v dialog opens, press 'Test Connection' button.
3.3 Check the spinner status when stops spinning

Result:
Virt-p2v spinner auto hidden when it stops spinning, you can see following information:
error: No conversion server given.
And "Next" button is grey(disabled).

Since spinner auto hidden when it is not running, move this bug from ON_QA to VERIFIED.

Comment 10 errata-xmlrpc 2016-11-03 18:00:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2576.html