1341564 – virt-p2v spinner should be hidden when it stops spinning

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1341564 - virt-p2v spinner should be hidden when it stops spinning

Summary: virt-p2v spinner should be hidden when it stops spinning

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	libguestfs
Sub Component:
Version:	7.3
Hardware:	x86_64
OS:	Unspecified
Priority:	low
Severity:	low
Target Milestone:	rc
Target Release:	---
Assignee:	Richard W.M. Jones
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:	P2V
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2016-06-01 09:59 UTC by keanli
Modified:	2016-11-03 18:00 UTC (History)
CC List:	6 users (show)
Fixed In Version:	libguestfs-1.32.5-5.el7
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2016-11-03 18:00:35 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)
virt-p2v_client (996.57 KB, image/png) 2016-06-01 09:59 UTC, keanli	no flags	Details
View All

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2016:2576	0	normal	SHIPPED_LIVE	Moderate: libguestfs and virt-p2v security, bug fix, and enhancement update	2016-11-03 12:06:51 UTC

Description keanli 2016-06-01 09:59:35 UTC

Created attachment 1163566 [details]
virt-p2v_client

Description of problem:
The load icon is always visible after finished the test connection  

Version-Release number of selected component (if applicable):
virt-p2v-1.32.4-1.el7.iso


How reproducible:
100%

Steps to Reproduce:
1.Boot the source machine into p2v client via iso
2.Input correct ip and root password, them click the "Test Connection " button 
3.The load icon still visible after finished the test connection.please check the screenshot in attachment 

Actual results:
As above description

Expected results:
For the load icon, I think the purpose is talk about customer the program is working for the current operation.So for improve UX, suggestion after finished load remove the load icon to invisible instead of static load icon.
 
Additional info:

Comment 1 Richard W.M. Jones 2016-06-01 11:07:02 UTC

https://github.com/libguestfs/libguestfs/commit/036a11f37927934132aab4fe01ed6f37c03fd805

Comment 3 keanli 2016-06-15 05:39:34 UTC

I can reproduce it with build:
virt-p2v-1.32.4-1.el7.iso

Verify it with build:
virt-p2v-1.32.5-2.el7.iso

Scenario 1:input correct conversion server ip with root's password on virt-p2v client
Steps:
1.1 Boot the source machine into p2v client via iso
1.2 Input correct conversion server ip with correct root's password, then click the "Test Connection " button
1.3 Check the spinner whether or not auto hidden when it stops spinning
Test result: Virt-p2v spinner auto hidden when it stops spinning,the "next" button is available

Scenario 2: input correct conversion server ip with incorrect root's password on virt-p2v client
Steps:
2.1 Boot the source machine into p2v client via iso
2.2 Input correct conversion server ip with incorrect root's password, then click the "Test Connection " button
2.3 Check the spinner whether or not auto hidden when it stops spinning
Test result:Virt-p2v spinner auto hidden when it stops spinning, the "next" button is unavailable

Verify Result:As above verify result,virt-p2v spinner can hidden when it stops spinning.The bug has been fixed , so move it to VERIFIED

Comment 4 Richard W.M. Jones 2016-06-17 20:18:01 UTC

Actually, a further commit is needed to fully fix this:

https://github.com/libguestfs/libguestfs/commit/e6a173d5d4f2fc59dee96d022fe3fc59339a046c

(Try pressing the 'Test Connection' button as soon as the
virt-p2v dialog opens, when the Server field is empty)

Comment 6 zhoujunqin 2016-06-22 08:19:12 UTC

I can reproduce this issue with build:
virt-p2v-1.32.4-3.el7.iso

Then try to verify this bug with new build:
virt-p2v-1.32.5-5.el7.iso

Steps:
Scenario 1: correct ip + correct user's password
Steps:
1.1 Boot the source machine into p2v client via iso
1.2 Input correct conversion server ip with correct root's password, then click the "Test Connection " button
1.3 Check the spinner status when stops spinning

Result:
Virt-p2v spinner auto hidden when it stops spinning, you can see following information:
Connected to the conversion server.
Press the "Next" button to configure the conversion process.
and Next button is enable.

Scenario 2: correct ip + incorrect user's password
Steps:
2.1 Boot the source machine into p2v client via iso
2.2 Input correct conversion server ip with incorrect root's password, then click the "Test Connection " button
2.3 Check the spinner status when stops spinning

Result:
Virt-p2v spinner auto hidden when it stops spinning, you can see following information:
unexpected password prompt:probably
the password supplied is wrong
And "Next" button is grey(disabled).

Scenario 3: Press 'Test Connection' button as soon as the virt-p2v dialog opens, when the Server field is empty.
3.1 Boot the source machine into p2v client via iso
3.2 When virt-p2v dialog opens, press 'Test Connection' button.
3.3 Check the spinner status when stops spinning

Result:
Virt-p2v spinner auto hidden when it stops spinning, you can see following information:
error: No conversion server given.
And "Next" button is grey(disabled).

Since spinner auto hidden when it is not running, move this bug from ON_QA to VERIFIED.

Comment 10 errata-xmlrpc 2016-11-03 18:00:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2576.html

Note You need to log in before you can comment on or make changes to this bug.