Bug 1344758

Summary:	[GSS] Removal of bricks in volume isn't prevented if remaining brick doesn't contain all the files
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Cal Calhoun <ccalhoun>
Component:	glusterd	Assignee:	Sanju <srakonde>
Status:	CLOSED ERRATA	QA Contact:	Sayalee <saraut>
Severity:	low	Docs Contact:
Priority:	high
Version:	rhgs-3.1	CC:	akrishna, amukherj, bkunal, ccalhoun, nchilaka, phil.coleman, pprakash, rhinduja, rhs-bugs, saraut, sheggodu, srakonde, storage-qa-internal, vbellur
Target Milestone:	---	Keywords:	ZStream
Target Release:	RHGS 3.5.z Batch Update 1
Hardware:	x86_64
OS:	Linux
Whiteboard:	dht-gss, dht-gss-ask, dht-3.2.0-proposed
Fixed In Version:	glusterfs-6.0-23	Doc Type:	Enhancement
Doc Text:	With this update removal of bricks will be aborted with a proper warning message if re-balance process has failed or there are some skipped files. However, users can still remove the brick by using 'force' option.	Story Points:	---
Clone Of:
Clones:	1514683 (view as bug list)		Environment:
Last Closed:	2020-01-30 06:42:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1514683
Bug Blocks:	1369781, 1408949, 1468976, 1472361, 1481177

Description Cal Calhoun 2016-06-10 16:12:31 UTC

Description of problem:

Customer wanted to test migration of data by adding and removing bricks to simulate moving between different storage.

1. Created a replicated volume made up of 2 x 279GB bricks.

2. Mounted as a gluster mount and then filed up untill approximately 500MB full.

3. Added additional bricks that were smaller, only 244MB.

4. Started removal of one 279GB brick which completed successfully.

5. Checked and there were still files left on the bricks being removed that couldn't be copied as the remaining brick wasn't large enough.

Removed brick without error, just a warning that files might be left behind.


Version-Release number of selected component (if applicable):

Gluster 3.7.5 (RHGS 3.1.2)


How reproducible:

Easily


Steps to Reproduce:

See above

Actual results:

Brick removal completed without error even though all files were not migrated.


Expected results:
Removal should fail or give more warning/require explicit approval before proceeding.

Additional info:

Comment 2 Atin Mukherjee 2016-06-10 16:23:00 UTC

remove brick commit functionality does have some cases where there could be data losses and that's why the CLI output throws up an warning message. I am moving this bug to zteam (DHT) for further comments.

Comment 8 Worker Ant 2017-11-18 02:12:39 UTC

REVISION POSTED: https://review.gluster.org/18801 (cli: WIP) posted (#2) for review on master by N Balachandran

Comment 25 Anjana KD 2020-01-29 17:19:48 UTC

have updated the doc text kindly verify the doc text- field.

Comment 27 errata-xmlrpc 2020-01-30 06:42:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0288