Bug 1345713

Summary:	[features/worm] - write FOP should pass for the normal files
Product:	[Community] GlusterFS	Reporter:	Karthik U S <ksubrahm>
Component:	unclassified	Assignee:	Karthik U S <ksubrahm>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	3.8.0	CC:	bugs, josferna, ksubrahm, ndevos, rtalur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1342259	Environment:
Last Closed:	2016-06-16 12:34:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1342259
Bug Blocks:	1317278

Description Karthik U S 2016-06-13 02:35:47 UTC

+++ This bug was initially created as a clone of Bug #1342259 +++

Description of problem:

The write FOP fails for the normal files. It should fail only for WORM or WORM-Retained files.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-06-02 15:44:43 EDT ---

REVIEW: http://review.gluster.org/14619 (features/worm: fixed issue with write FOP for normal files) posted (#1) for review on master by Karthik U S (ksubrahm)

--- Additional comment from Vijay Bellur on 2016-06-06 06:44:24 EDT ---

REVIEW: http://review.gluster.org/14619 (features/worm: fixed issue with write FOP for normal files) posted (#2) for review on master by Karthik U S (ksubrahm)

Comment 1 Vijay Bellur 2016-06-13 03:07:08 UTC

REVIEW: http://review.gluster.org/14705 (features/worm: fixed issue with write FOP for normal files) posted (#1) for review on release-3.8 by Karthik U S (ksubrahm)

Comment 2 Vijay Bellur 2016-06-13 13:32:21 UTC

COMMIT: http://review.gluster.org/14705 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit f8e8a6ea010d230c7128e628532bbaaf1e8378c3
Author: karthik-us <ksubrahm>
Date:   Mon Jun 13 08:23:06 2016 +0530

    features/worm: fixed issue with write FOP for normal files
    
    The write FOPs on normal files were being blocked after the recent change.
    It should fail only for the WORM and WORM-Retained files, and should pass
    for a normal file.
    Using auto-commit period to check for dormant files instead of retention period.
    
    Backport of http://review.gluster.org/#/c/14619/
    
    > Change-Id: I30f82d4de2ea2c59c1eb7b4449ba6a60e568cfd5
    > BUG: 1342259
    > Signed-off-by: karthik-us <ksubrahm>
    
    Change-Id: I9c4ad589dd82cd33eecf207d9ed810a9d01f0f46
    BUG: 1345713
    Signed-off-by: karthik-us <ksubrahm>
    Reviewed-on: http://review.gluster.org/14705
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-06-16 12:34:04 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user