Bug 1345791

Summary: Cannot go fullscreen from user portal (wrong value in console.vv)
Product: [oVirt] ovirt-engine Reporter: Radek Duda <rduda>
Component: Frontend.UserPortalAssignee: Marek Libra <mlibra>
Status: CLOSED CURRENTRELEASE QA Contact: meital avital <mavital>
Severity: medium Docs Contact:
Priority: high    
Version: 4.0.0CC: astepano, bugs, gklein, lsurette, melewis, mgoldboi, michal.skrivanek, mlibra, rbalakri, rduda, Rhev-m-bugs, spice-qe-bugs, srevivo, tjelinek, ykaul
Target Milestone: ovirt-4.0.1Flags: rule-engine: ovirt-4.0.z+
mgoldboi: planning_ack+
tjelinek: devel_ack+
rule-engine: testing_ack+
Target Release: 4.0.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Previously, the full screen option from the console options window was ignored. Now, the console is able to be in full screen.
Story Points: ---
Clone Of:
: 1349368 (view as bug list) Environment:
Last Closed: 2016-08-12 14:11:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1349368    

Description Radek Duda 2016-06-13 08:13:53 UTC
Description of problem:
Setting fullscreen mode in user portal does not work. Wrong value stored in console.vv file.


Version-Release number of selected component (if applicable):
ovirt-engine-4.0.0.2-0.1.el7ev.noarch


How reproducible: always


Steps to Reproduce:
1.Go to rhev-m user portal
2.Edit console options -> open in fullscreen
3.Clicke CONSOLE and launch remote-viewer

Actual results:
remote-viewer opens guest VM in non-fullscreen mode


Expected results:
fullscreen mode expected


Additional info:there is wrong option saved in console.vv file: fullscreen=0

Comment 1 Red Hat Bugzilla Rules Engine 2016-06-14 05:23:59 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 2 Tomas Jelinek 2016-06-14 06:38:37 UTC
I think it is a regression introduced by https://gerrit.ovirt.org/#/c/55573/ which added an option to control the full-screen setting globally. It seems it may have broken the override.

As a workaround, you could change the global setting using engine-config (the FullScreenUserportalExtendedDefault or FullScreenUserportalBasicDefault keys).

@Marek, could you please check if the VM overridden value from local storage is respected?

Comment 3 Radek Duda 2016-06-22 14:20:58 UTC
Similar issue applies for Disable smartcard Console option. In console.vv file is option enable-smartcard always =1 and does not depend on the checkbox Disable smartcard in Console options.

Comment 4 Marek Libra 2016-06-23 07:51:06 UTC
I've just checked on recent 4.0.1-master and the 'Smartcard Enabled' checkbox in Edit VM dialog is working properly (the .vv file has both 0 and 1 values, accordingly).

Radek, what version did you try? I can fix it once reproduced.

Comment 5 Radek Duda 2016-06-23 08:46:02 UTC
Yes I know what you mean, but I am not talking about 'Smartcard Enabled' checkbox, but about 'Disable smartcard' option in 'Edit console options' dialog (next to CONSOLE button in super-user-portal (Extended)). The 'Disable smartcard' checkbox becomes visible only if 'Smartcard Enabled' option is checked. There is no difference  in .vv file (except password change) whether I check or uncheck the 'Disable smartcard' checkbox.
Tested on:
ovirt-engine-4.0.0.6-0.1.el7ev.noarch

also tried on rhev-m 3.6: version 3.6.4.1-0.1.el6,
where is the same problem.

I think that additional checkbox 'Disable smartcard' is present for some security reason.. you can easily disable smartcard for particular .vv file.

Comment 6 Marek Libra 2016-06-23 09:38:26 UTC
Yep, it's not working. Patch will follow.

Comment 7 Michal Skrivanek 2016-07-05 05:19:58 UTC
(In reply to Marek Libra from comment #6)
> Yep, it's not working. Patch will follow.

which patch? part of this bug?

Comment 8 Marek Libra 2016-07-07 07:12:39 UTC
Yes, gerrit #59329 . Sorry for misunderstanding.

Comment 9 meital avital 2016-08-11 15:11:22 UTC
Verified on version: 4.0.2.6-0.1.el7ev

Verified steps:
1.Go to rhev-m user portal
2.Edit console options -> Enable the checkbox open in fullscreen
3.Clicke CONSOLE and launch remote-viewer 

-> remote-viewer opens guest VM in fullscreen mode