Bug 1345791 - Cannot go fullscreen from user portal (wrong value in console.vv)
Summary: Cannot go fullscreen from user portal (wrong value in console.vv)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.UserPortal
Version: 4.0.0
Hardware: x86_64
OS: Linux
high
medium
Target Milestone: ovirt-4.0.1
: 4.0.0
Assignee: Marek Libra
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks: 1349368
TreeView+ depends on / blocked
 
Reported: 2016-06-13 08:13 UTC by Radek Duda
Modified: 2016-08-16 04:46 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, the full screen option from the console options window was ignored. Now, the console is able to be in full screen.
Clone Of:
: 1349368 (view as bug list)
Environment:
Last Closed: 2016-08-12 14:11:24 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.0.z+
mgoldboi: planning_ack+
tjelinek: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 59152 0 master MERGED webadmin: User setting of FullScreen propagated to .vv 2016-06-16 09:05:56 UTC
oVirt gerrit 59329 0 ovirt-engine-4.0 MERGED webadmin: User setting of FullScreen propagated to .vv 2016-06-16 12:58:57 UTC

Description Radek Duda 2016-06-13 08:13:53 UTC 
Description of problem:
Setting fullscreen mode in user portal does not work. Wrong value stored in console.vv file.


Version-Release number of selected component (if applicable):
ovirt-engine-4.0.0.2-0.1.el7ev.noarch


How reproducible: always


Steps to Reproduce:
1.Go to rhev-m user portal
2.Edit console options -> open in fullscreen
3.Clicke CONSOLE and launch remote-viewer

Actual results:
remote-viewer opens guest VM in non-fullscreen mode


Expected results:
fullscreen mode expected


Additional info:there is wrong option saved in console.vv file: fullscreen=0
Comment 1 Red Hat Bugzilla Rules Engine 2016-06-14 05:23:59 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 2 Tomas Jelinek 2016-06-14 06:38:37 UTC 
I think it is a regression introduced by https://gerrit.ovirt.org/#/c/55573/ which added an option to control the full-screen setting globally. It seems it may have broken the override.

As a workaround, you could change the global setting using engine-config (the FullScreenUserportalExtendedDefault or FullScreenUserportalBasicDefault keys).

@Marek, could you please check if the VM overridden value from local storage is respected?
Comment 3 Radek Duda 2016-06-22 14:20:58 UTC 
Similar issue applies for Disable smartcard Console option. In console.vv file is option enable-smartcard always =1 and does not depend on the checkbox Disable smartcard in Console options.
Comment 4 Marek Libra 2016-06-23 07:51:06 UTC 
I've just checked on recent 4.0.1-master and the 'Smartcard Enabled' checkbox in Edit VM dialog is working properly (the .vv file has both 0 and 1 values, accordingly).

Radek, what version did you try? I can fix it once reproduced.
Comment 5 Radek Duda 2016-06-23 08:46:02 UTC 
Yes I know what you mean, but I am not talking about 'Smartcard Enabled' checkbox, but about 'Disable smartcard' option in 'Edit console options' dialog (next to CONSOLE button in super-user-portal (Extended)). The 'Disable smartcard' checkbox becomes visible only if 'Smartcard Enabled' option is checked. There is no difference  in .vv file (except password change) whether I check or uncheck the 'Disable smartcard' checkbox.
Tested on:
ovirt-engine-4.0.0.6-0.1.el7ev.noarch

also tried on rhev-m 3.6: version 3.6.4.1-0.1.el6,
where is the same problem.

I think that additional checkbox 'Disable smartcard' is present for some security reason.. you can easily disable smartcard for particular .vv file.
Comment 6 Marek Libra 2016-06-23 09:38:26 UTC 
Yep, it's not working. Patch will follow.
Comment 7 Michal Skrivanek 2016-07-05 05:19:58 UTC 
(In reply to Marek Libra from comment #6)
> Yep, it's not working. Patch will follow.

which patch? part of this bug?
Comment 8 Marek Libra 2016-07-07 07:12:39 UTC 
Yes, gerrit #59329 . Sorry for misunderstanding.
Comment 9 meital avital 2016-08-11 15:11:22 UTC 
Verified on version: 4.0.2.6-0.1.el7ev

Verified steps:
1.Go to rhev-m user portal
2.Edit console options -> Enable the checkbox open in fullscreen
3.Clicke CONSOLE and launch remote-viewer 

-> remote-viewer opens guest VM in fullscreen mode
Note You need to log in before you can comment on or make changes to this bug.