Bug 1347148

Summary:	Localization strings for SSO module needs to use indexes for string substitutions to be translatable
Product:	[oVirt] ovirt-engine	Reporter:	Martin Perina <mperina>
Component:	AAA	Assignee:	Ravi Nori <rnori>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Gonza <grafuls>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.0.0	CC:	bugs
Target Milestone:	ovirt-4.0.1	Keywords:	CodeChange
Target Release:	4.0.0	Flags:	rule-engine: ovirt-4.0.z+ rule-engine: planning_ack+ mperina: devel_ack+ rule-engine: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-19 06:26:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1323484

Description Martin Perina 2016-06-16 07:10:42 UTC

Description of problem:

Currently localization strings for SSO module uses non-indexed format for string substitutions, for example:

  The request contains unsupported parameter value '%s' for parameter '%s'.

We need to add indexes for those string substitutions, because during translations to different languages the order of those substitutions may change. So the string above needs to be updated to:

  The request contains unsupported parameter value '%1$s' for parameter '%2$s'.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Gonza 2016-06-24 13:36:50 UTC

Basic sanity run on:
rhevm-4.0.0.5-0.1.el7ev.noarch

2016-06-24 16:35:24,246 ERROR [org.ovirt.engine.core.sso.servlets.InteractiveAuthServlet] (default task-21) [] Cannot authenticate user 'admin@internal': The user name or password is incorrect.

Comment 2 Sandro Bonazzola 2016-07-19 06:26:20 UTC

Since the problem described in this bug report should be
resolved in oVirt 4.0.1 released on July 19th 2016, it has been closed with a
resolution of CURRENT RELEASE.

For information on the release, and how to update to this release, follow the link below.

If the solution does not work for you, open a new bug report.

http://www.ovirt.org/release/4.0.1/