Bug 1347355

Summary:	glusterd: SuSE build system error for incorrect strcat, strncat usage
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	glusterd	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.0	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1347354	Environment:
Last Closed:	2016-07-08 14:43:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1347354
Bug Blocks:

Description Kaleb KEITHLEY 2016-06-16 15:11:38 UTC

+++ This bug was initially created as a clone of Bug #1347354 +++

Description of problem:

SuSE build system does post-compile analysis of compile warnings and
aborts the build of packages for a warning in xlators/mgmt/glusterd/src/glusted-geo-rep.c's glusterd_op_stage_gsync_create()


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-06-16 15:31:59 UTC

REVIEW: http://review.gluster.org/14746 (glusterd: unsafe strcat, strncat use in glusterd_op_stage_gsync_create()) posted (#1) for review on release-3.8 by Kaleb KEITHLEY (kkeithle)

Comment 2 Vijay Bellur 2016-06-17 09:30:59 UTC

COMMIT: http://review.gluster.org/14746 committed in release-3.8 by Kaleb KEITHLEY (kkeithle) 
------
commit 1d42e5e2312a8de45d9c83350f3e3260afba03ae
Author: Kaleb S KEITHLEY <kkeithle>
Date:   Thu Jun 16 11:29:40 2016 -0400

    glusterd: unsafe strcat, strncat use in glusterd_op_stage_gsync_create()
    
    SuSE build system post-compile analysis aborts pkg build due to
    unsafe strcat, strncat usage.
    
    mainline
    >    BUG: 1347354
    >    http://review.gluster.org/14745
    
    Change-Id: I52ac41e1172d0c1e5695a91b9f731cc9e7de4db4
    BUG: 1347355
    Signed-off-by: Kaleb S KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/14746
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Avra Sengupta <asengupt>

Comment 3 Niels de Vos 2016-07-08 14:43:58 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.1, please open a new bug report.

glusterfs-3.8.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/156
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user