Bug 1347354 - glusterd: SuSE build system error for incorrect strcat, strncat usage
Summary: glusterd: SuSE build system error for incorrect strcat, strncat usage
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1347355
TreeView+ depends on / blocked
 
Reported: 2016-06-16 15:10 UTC by Kaleb KEITHLEY
Modified: 2016-12-06 05:26 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1347355 (view as bug list)
Environment:
Last Closed: 2016-12-06 05:26:30 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Kaleb KEITHLEY 2016-06-16 15:10:34 UTC 
Description of problem:

SuSE build system does post-compile analysis of compile warnings and
aborts the build of packages for a warning in xlators/mgmt/glusterd/src/glusted-geo-rep.c's glusterd_op_stage_gsync_create()


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Vijay Bellur 2016-06-16 15:28:05 UTC 
REVIEW: http://review.gluster.org/14745 (glusterd: unsafe strcat, strncat use in glusterd_op_stage_gsync_create()) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)
Comment 2 Vijay Bellur 2016-06-16 19:31:53 UTC 
COMMIT: http://review.gluster.org/14745 committed in master by Jeff Darcy (jdarcy) 
------
commit ae4a410cb411c3f1b5ebac9d49d47e2fc00c9a74
Author: Kaleb S KEITHLEY <kkeithle>
Date:   Thu Jun 16 11:24:30 2016 -0400

    glusterd: unsafe strcat, strncat use in glusterd_op_stage_gsync_create()
    
    SuSE build system post-compile analysis aborts pkg build due to
    unsafe strcat, strncat usage.
    
    Change-Id: I52ac41e1172d0c1e5695a91b9f731cc9e7de4db4
    BUG: 1347354
    Signed-off-by: Kaleb S KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/14745
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
Note You need to log in before you can comment on or make changes to this bug.