Bug 1347857

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 11 files have unknown license. Detailed
     output of licensecheck in /tmp/rubygem-prawn-
     templates/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gems,
     /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
     prawn-templates-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: When checking ruby code, install the ruby plugin.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: rubygem-prawn-templates-0.0.4-1.fc25.noarch.rpm
          rubygem-prawn-templates-doc-0.0.4-1.fc25.noarch.rpm
          rubygem-prawn-templates-0.0.4-1.fc25.src.rpm
rubygem-prawn-templates.noarch: W: no-documentation
rubygem-prawn-templates.noarch: E: incorrect-fsf-address /usr/share/licenses/rubygem-prawn-templates/GPLv2
3 packages and 0 specfiles checked; 1 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
rubygem-prawn-templates.noarch: W: no-documentation
rubygem-prawn-templates.noarch: E: incorrect-fsf-address /usr/share/licenses/rubygem-prawn-templates/GPLv2
2 packages and 0 specfiles checked; 1 errors, 1 warnings.



Requires
--------
rubygem-prawn-templates (rpmlib, GLIBC filtered):
    ruby(rubygems)
    rubygem(pdf-core)
    rubygem(pdf-reader)
    rubygem(prawn)

rubygem-prawn-templates-doc (rpmlib, GLIBC filtered):
    rubygem-prawn-templates



Provides
--------
rubygem-prawn-templates:
    rubygem(prawn-templates)
    rubygem-prawn-templates

rubygem-prawn-templates-doc:
    rubygem-prawn-templates-doc



Source checksums
----------------
https://raw.githubusercontent.com/prawnpdf/prawn-templates/master/GPLv2 :
  CHECKSUM(SHA256) this package     : 32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670
  CHECKSUM(SHA256) upstream package : 32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670
https://raw.githubusercontent.com/prawnpdf/prawn-templates/master/GPLv3 :
  CHECKSUM(SHA256) this package     : 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903
  CHECKSUM(SHA256) upstream package : 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903
https://rubygems.org/gems/prawn-templates-0.0.4.gem :
  CHECKSUM(SHA256) this package     : cf2ed38bc552f827c0782d2f063124670d6a5908d4c545e2632e31eddc198651
  CHECKSUM(SHA256) upstream package : cf2ed38bc552f827c0782d2f063124670d6a5908d4c545e2632e31eddc198651
https://raw.githubusercontent.com/prawnpdf/prawn-templates/master/COPYING :
  CHECKSUM(SHA256) this package     : cf2a5e36070e388ddd3a8a8cf2b44e133507cbc3840355db18d4643c88926963
  CHECKSUM(SHA256) upstream package : cf2a5e36070e388ddd3a8a8cf2b44e133507cbc3840355db18d4643c88926963
https://raw.githubusercontent.com/prawnpdf/prawn-templates/master/LICENSE :
  CHECKSUM(SHA256) this package     : 882971fb8027a089b754ebacbd987bbb776f5eff87518655b8789448f383bc7a
  CHECKSUM(SHA256) upstream package : 882971fb8027a089b754ebacbd987bbb776f5eff87518655b8789448f383bc7a


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -r -m fedora-rawhide-x86_64 -n /home/fale/rpmbuild/SRPMS/rubygem-prawn-templates-0.0.4-1.fc24.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Congratulations, the package is approved!

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-prawn-templates

rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc23 rubygem-prawn-icon-1.1.0-1.fc23 rubygem-prawn-svg-0.25.1-1.fc23 rubygem-css_parser-1.4.2-1.fc23 rubygem-prawn-table-0.2.2-1.fc23 rubygem-prawn-manual_builder-0.2.0-1.fc23 rubygem-prawn-templates-0.0.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f072509871

rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc24 rubygem-prawn-icon-1.1.0-1.fc24 rubygem-prawn-svg-0.25.1-1.fc24 rubygem-css_parser-1.4.2-1.fc24 rubygem-prawn-table-0.2.2-1.fc24 rubygem-prawn-manual_builder-0.2.0-1.fc24 rubygem-prawn-templates-0.0.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3002f036fc

rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc24, rubygem-css_parser-1.4.2-1.fc24, rubygem-prawn-icon-1.1.0-1.fc24, rubygem-prawn-manual_builder-0.2.0-1.fc24, rubygem-prawn-svg-0.25.1-1.fc24, rubygem-prawn-table-0.2.2-1.fc24, rubygem-prawn-templates-0.0.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3002f036fc

rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc23, rubygem-css_parser-1.4.2-1.fc23, rubygem-prawn-icon-1.1.0-1.fc23, rubygem-prawn-manual_builder-0.2.0-1.fc23, rubygem-prawn-svg-0.25.1-1.fc23, rubygem-prawn-table-0.2.2-1.fc23, rubygem-prawn-templates-0.0.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f072509871

rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc24, rubygem-css_parser-1.4.2-1.fc24, rubygem-prawn-icon-1.1.0-1.fc24, rubygem-prawn-manual_builder-0.2.0-1.fc24, rubygem-prawn-svg-0.25.1-1.fc24, rubygem-prawn-table-0.2.2-1.fc24, rubygem-prawn-templates-0.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc23, rubygem-css_parser-1.4.2-1.fc23, rubygem-prawn-icon-1.1.0-1.fc23, rubygem-prawn-manual_builder-0.2.0-1.fc23, rubygem-prawn-svg-0.25.1-1.fc23, rubygem-prawn-table-0.2.2-1.fc23, rubygem-prawn-templates-0.0.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.