Bug 1349284

Summary: [tiering]: Files of size greater than that of high watermark level should not be promoted
Product: [Community] GlusterFS Reporter: Milind Changire <mchangir>
Component: tieringAssignee: Milind Changire <mchangir>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, dlambrig, kramdoss, nchilaka, rkavunga
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: tier-migration
Fixed In Version: glusterfs-3.9.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1299841
: 1362198 (view as bug list) Environment:
Last Closed: 2017-03-27 18:17:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1362198    

Comment 1 Vijay Bellur 2016-06-23 07:18:47 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote estimated block consumption > hi watermark) posted (#1) for review on master by Milind Changire (mchangir)

Comment 2 Vijay Bellur 2016-06-23 07:59:25 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote estimated block consumption > hi watermark) posted (#2) for review on master by Milind Changire (mchangir)

Comment 3 Vijay Bellur 2016-06-29 10:31:50 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#3) for review on master by Milind Changire (mchangir)

Comment 4 Vijay Bellur 2016-07-05 10:27:23 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#4) for review on master by Milind Changire (mchangir)

Comment 5 Vijay Bellur 2016-07-05 16:40:26 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#5) for review on master by Milind Changire (mchangir)

Comment 6 Vijay Bellur 2016-07-12 06:44:12 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#6) for review on master by Milind Changire (mchangir)

Comment 7 Vijay Bellur 2016-07-12 13:06:15 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#7) for review on master by Milind Changire (mchangir)

Comment 8 Vijay Bellur 2016-07-15 08:57:49 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#8) for review on master by Milind Changire (mchangir)

Comment 9 Mohammed Rafi KC 2016-07-15 10:33:30 UTC
upstream master patch : http://review.gluster.org/#/c/14780/

Comment 10 Vijay Bellur 2016-07-19 10:54:31 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#9) for review on master by Milind Changire (mchangir)

Comment 11 Vijay Bellur 2016-07-20 06:52:21 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#10) for review on master by Milind Changire (mchangir)

Comment 12 Vijay Bellur 2016-07-20 13:04:04 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#11) for review on master by Milind Changire (mchangir)

Comment 13 Vijay Bellur 2016-07-21 07:30:03 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#12) for review on master by Milind Changire (mchangir)

Comment 14 Vijay Bellur 2016-07-27 13:54:35 UTC
REVIEW: http://review.gluster.org/14780 (cluster/tier: dont promote if estimated block consumption > hi watermark) posted (#13) for review on master by Milind Changire (mchangir)

Comment 15 Vijay Bellur 2016-07-29 14:14:40 UTC
COMMIT: http://review.gluster.org/14780 committed in master by Dan Lambright (dlambrig) 
------
commit 1f4e41e8c2f5f4af4564caba0a08996853f089f4
Author: Milind Changire <mchangir>
Date:   Thu Jun 23 12:37:51 2016 +0530

    cluster/tier: dont promote if estimated block consumption > hi watermark
    
    Add test to fail promotion if estimated block consumption grows
    beyond hi watermark.
    
    Skip file migrations until next cycle if tier_get_fs_stat() fails
    in tier_migrate_using_query_file()
    
    Change-Id: Ice04572fa739c09109c4433e65965197482a7beb
    BUG: 1349284
    Signed-off-by: Milind Changire <mchangir>
    Reviewed-on: http://review.gluster.org/14780
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: mohammed rafi  kc <rkavunga>
    Reviewed-by: Dan Lambright <dlambrig>

Comment 16 Shyamsundar 2017-03-27 18:17:28 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/