Bug 1349372

Summary:	Review Request: perl-Module-Install-RDF - Advanced meta-data for your distribution
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Module-Install-RDF-0.009-1.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-24 05:48:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1321042
Bug Blocks:

Description Petr Pisar 2016-06-23 10:48:43 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Module-Install-RDF/perl-Module-Install-RDF.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Module-Install-RDF/perl-Module-Install-RDF-0.009-1.fc25.src.rpm
Description:
These Perl modules read all the RDF files it can find in the distribution's
"meta" directory and expose them for other modules to make use of them. They
also allow you to write out a combined graph using Turtle.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-23 13:38:53 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Module-Install-RDF-0.009-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.5.0
      1 perl(:VERSION) >= 5.8.0
      1 perl(Module::Install::Base) >= 1.0
      1 perl(Object::ID)
      1 perl(RDF::Trine) >= 0.135
      1 perl(RDF::TrineX::Parser::Pretdsl)
      1 perl(URI::file) >= 4.0
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
$ rpm -qp --suggests perl-Module-Install-RDF-0.009-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(RDF::TrineX::Serializer::MockTurtleSoup)
Binary requires are Ok.

$ rpm -qp --provides perl-Module-Install-RDF-0.009-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(Module::Install::Admin::RDF) = 0.009
      1 perl(Module::Install::RDF) = 0.009
      1 perl-Module-Install-RDF = 0.009-1.fc25
Binary provides are Ok.

$ rpmlint perl-Module-Install-RDF*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires:
FIX: Please add BR 'coreutils' - perl-Module-Install-RDF.spec:60
TODO: perl(strict) is not used by Makefile.PL, it is Run-time BRs

The rest of BuildRequires are listed.

Please correct 'FIX' issue and consider fixing 'TODO' item

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-06-23 14:10:44 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Module-Install-RDF

Comment 3 Petr Pisar 2016-06-24 05:48:09 UTC

Thank you for the review and the repository.

I fixed the dependencies.