Bug 1349380 (libzmf)

Summary:	Review Request: libzmf - a library for import of Zoner document formats
Product:	[Fedora] Fedora	Reporter:	David Tardon <dtardon>
Component:	Package Review	Assignee:	David Tardon <dtardon>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dtardon, package-review, rc040203
Target Milestone:	---	Flags:	ignatenko: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-08 13:58:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Tardon 2016-06-23 11:12:34 UTC

Spec URL: https://dtardon.fedorapeople.org/rpm/libzmf.spec
SRPM URL: https://dtardon.fedorapeople.org/rpm/libzmf-0.0.0-1.fc24.src.rpm
Description: libzmf is library providing ability to interpret and import Zoner document formats into various applications. Currently it only supports Zoner Callisto/Draw v 4-5.
Fedora Account System Username: dtardon

This will be a dependency of libreoffice 5.3.

Comment 1 David Tardon 2016-06-23 11:22:23 UTC

Copr builds: https://copr.fedoraproject.org/coprs/dtardon/pending-review/build/361498/

Comment 2 David Tardon 2016-09-07 13:42:06 UTC

Spec URL: https://dtardon.fedorapeople.org/rpm/libzmf.spec
SRPM URL: https://dtardon.fedorapeople.org/rpm/libzmf-0.0.1-1.fc24.src.rpm
Copr builds: https://copr.fedorainfracloud.org/coprs/dtardon/pending-review/build/450316/

Comment 3 Igor Gnatenko 2016-09-07 14:10:00 UTC

Looks like I completely forgot about this, sorry.

> make %{?_smp_mflags}
%make_build

> make install DESTDIR=%{buildroot}
%make_install

* Missing BuildRequires: gcc-c++

Comment 4 Ralf Corsepius 2016-09-08 05:33:52 UTC

(In reply to Igor Gnatenko from comment #3)
> Looks like I completely forgot about this, sorry.
> 
> > make %{?_smp_mflags}
> %make_build
> 
> > make install DESTDIR=%{buildroot}
> %make_install

Igor, enforcing these macros is not helpful. They are not mandatory.

Comment 5 Igor Gnatenko 2016-09-08 06:39:25 UTC

#------------------------------------------------------------------------------
# Tested features of make
# Output syncronization for parallel make:
%_make_output_sync %(! %{__make} --version -O >/dev/null 2>&1 || echo -O)

#------------------------------------------------------------------------------
# The "make" analogue, hiding the _smp_mflags magic from specs
%make_build %{__make} %{_make_output_sync} %{?_smp_mflags}


Basically %make_build is not anymore same as make %{?_smp_mflags} and I will work with FPC to enforce such macro.

Comment 6 Ralf Corsepius 2016-09-08 07:16:09 UTC

@Igor, all these macros do is to obscure what they actually do. This is featuritis and serves no technical purpose.

Enforcing them is infantile bureaucracy.

Comment 7 Igor Gnatenko 2016-09-08 07:26:34 UTC

(In reply to Ralf Corsepius from comment #6)
> @Igor, all these macros do is to obscure what they actually do. This is
> featuritis and serves no technical purpose.
> 
> Enforcing them is infantile bureaucracy.

will you force people to remember what is %{_make_output_sync} and all other macro which could be added in future? Answering why we need macro for this - EL6/EL7 GNU Make doesn't support "-O", but 4.0+ does.

Comment 8 Gwyn Ciesla 2016-09-08 12:19:02 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libzmf