Bug 1349380 (libzmf) - Review Request: libzmf - a library for import of Zoner document formats
Summary: Review Request: libzmf - a library for import of Zoner document formats
Keywords:
Status: CLOSED RAWHIDE
Alias: libzmf
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Tardon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-23 11:12 UTC by David Tardon
Modified: 2016-09-08 13:58 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-08 13:58:29 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)

Description David Tardon 2016-06-23 11:12:34 UTC
Spec URL: https://dtardon.fedorapeople.org/rpm/libzmf.spec
SRPM URL: https://dtardon.fedorapeople.org/rpm/libzmf-0.0.0-1.fc24.src.rpm
Description: libzmf is library providing ability to interpret and import Zoner document formats into various applications. Currently it only supports Zoner Callisto/Draw v 4-5.
Fedora Account System Username: dtardon

This will be a dependency of libreoffice 5.3.

Comment 3 Igor Gnatenko 2016-09-07 14:10:00 UTC
Looks like I completely forgot about this, sorry.

> make %{?_smp_mflags}
%make_build

> make install DESTDIR=%{buildroot}
%make_install

* Missing BuildRequires: gcc-c++

Comment 4 Ralf Corsepius 2016-09-08 05:33:52 UTC
(In reply to Igor Gnatenko from comment #3)
> Looks like I completely forgot about this, sorry.
> 
> > make %{?_smp_mflags}
> %make_build
> 
> > make install DESTDIR=%{buildroot}
> %make_install

Igor, enforcing these macros is not helpful. They are not mandatory.

Comment 5 Igor Gnatenko 2016-09-08 06:39:25 UTC
#------------------------------------------------------------------------------
# Tested features of make
# Output syncronization for parallel make:
%_make_output_sync %(! %{__make} --version -O >/dev/null 2>&1 || echo -O)

#------------------------------------------------------------------------------
# The "make" analogue, hiding the _smp_mflags magic from specs
%make_build %{__make} %{_make_output_sync} %{?_smp_mflags}


Basically %make_build is not anymore same as make %{?_smp_mflags} and I will work with FPC to enforce such macro.

Comment 6 Ralf Corsepius 2016-09-08 07:16:09 UTC
@Igor, all these macros do is to obscure what they actually do. This is featuritis and serves no technical purpose.

Enforcing them is infantile bureaucracy.

Comment 7 Igor Gnatenko 2016-09-08 07:26:34 UTC
(In reply to Ralf Corsepius from comment #6)
> @Igor, all these macros do is to obscure what they actually do. This is
> featuritis and serves no technical purpose.
> 
> Enforcing them is infantile bureaucracy.

will you force people to remember what is %{_make_output_sync} and all other macro which could be added in future? Answering why we need macro for this - EL6/EL7 GNU Make doesn't support "-O", but 4.0+ does.

Comment 8 Gwyn Ciesla 2016-09-08 12:19:02 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libzmf


Note You need to log in before you can comment on or make changes to this bug.