Bug 1349520

Summary:	Review Request: perl-lexical-underscore - Access your caller's lexical underscore
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-lexical-underscore-0.003-1.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-24 14:29:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1349524

Description Petr Pisar 2016-06-23 15:13:47 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-lexical-underscore/perl-lexical-underscore.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-lexical-underscore/perl-lexical-underscore-0.003-1.fc25.src.rpm
Description:
Starting with Perl 5.10, it is possible to create a lexical version of the
Perl default variable $_.

It is occasionally useful for a subroutine to be able to access its caller's
$_ variable regardless of whether it was lexical or not. The "(_)" sub
prototype is the official way to do so, however there are sometimes
disadvantages to this.

The "lexical::underscore" function returns a scalar reference to either
a lexical $_ variable somewhere up the call stack (using PadWalker magic), or
to the global $_ if there was no lexical version.


Fedora Account System Username: ppisar


This package does not make sense with perl 5.24, but it's required as a compatibility layer by other modules.

Comment 1 Jitka Plesnikova 2016-06-24 08:44:46 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-lexical-underscore-0.003-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.8.0
      1 perl(if)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-lexical-underscore-0.003-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(lexical::underscore) = 0.003
      1 perl-lexical-underscore = 0.003-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-lexical-underscore*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-06-24 13:11:52 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-lexical-underscore

Comment 3 Petr Pisar 2016-06-24 14:29:39 UTC

Thank you for the review and the repository.