Bug 1349524 - Review Request: perl-Scalar-Does - Check an object implements an interface
Summary: Review Request: perl-Scalar-Does - Check an object implements an interface
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1349520
Blocks: 1349859
TreeView+ depends on / blocked
 
Reported: 2016-06-23 15:25 UTC by Petr Pisar
Modified: 2016-06-27 14:25 UTC (History)
2 users (show)

Fixed In Version: perl-Scalar-Does-0.202-1.fc25
Clone Of:
Environment:
Last Closed: 2016-06-27 14:25:49 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-06-23 15:25:15 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Scalar-Does/perl-Scalar-Does.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Scalar-Does/perl-Scalar-Does-0.202-1.fc25.src.rpm
Description:
It has long been noted that Perl would benefit from a does() built-in. A
check that ref($thing) eq 'ARRAY' doesn't allow you to accept an object
that uses overloading to provide an array-like interface. This package
delivers Scalar::Does Perl module that can do it.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-27 08:43:30 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Scalar-Does-0.202-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.8.0
      1 perl(B)
      1 perl(Carp) >= 0
      1 perl(Exporter::Tiny) >= 0.026
      1 perl(Scalar::Util) >= 1.24
      1 perl(Type::Tiny) >= 0.004
      1 perl(Types::Standard) >= 0.004
      1 perl(URI::file)
      1 perl(base)
      1 perl(constant)
      1 perl(if)
      1 perl(lexical::underscore)
      1 perl(namespace::clean) >= 0.19
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Scalar-Does-0.202-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(IO::Detect) = 0.202
      1 perl(IO::Detect::SmartMatcher) = 0.202
      1 perl(Scalar::Does) = 0.202
      1 perl(Scalar::Does::MooseTypes) = 0.202
      1 perl(Scalar::Does::RoleChecker) = 0.202
      1 perl-Scalar-Does = 0.202-1.fc25
Binary provides are Ok.

$ rpmlint perl-Scalar-Does*
perl-Scalar-Does.noarch: W: spelling-error %description -l en_US eq -> e, q, seq
perl-Scalar-Does.src: W: spelling-error %description -l en_US eq -> e, q, seq
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package is good.
Approved

Comment 2 Gwyn Ciesla 2016-06-27 13:56:49 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Scalar-Does

Comment 3 Petr Pisar 2016-06-27 14:25:49 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.