Bug 1349910

Summary:	Review Request: perl-Module-Install-Copyright - Package a COPYRIGHT file with a distribution
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Module-Install-Copyright-0.009-1.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-29 13:43:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1349859, 1349904
Bug Blocks:

Description Petr Pisar 2016-06-24 14:04:08 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Module-Install-Copyright/perl-Module-Install-Copyright.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Module-Install-Copyright/perl-Module-Install-Copyright-0.009-1.fc25.src.rpm
Description:
This Module::Install plug-in extracts copyright and licensing information from
embedded POD and/or RDF meta-data included in the distribution, and outputs it
as a text file called COPYRIGHT which should roughly conform to the Debian
copyright file format.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-29 08:51:53 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Module-Install-Copyright-0.009-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.6.0
      1 perl(:VERSION) >= 5.8.0
      1 perl(List::MoreUtils)
      1 perl(Module::Install::Admin::RDF) >= 0.003
      1 perl(Module::Install::Base)
      1 perl(Module::Install::Contributors) >= 0.001
      1 perl(Module::Manifest)
      1 perl(MooX::Struct)
      1 perl(Path::Class)
      1 perl(RDF::Trine)
      1 perl(RDF::Trine::Namespace)
      1 perl(Software::License)
      1 perl(Software::LicenseUtils)
      1 perl(base)
      1 perl(constant)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Module-Install-Copyright-0.009-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(Module::Install::Admin::Copyright) = 0.009
      1 perl(Module::Install::Admin::Credits) = 0.009
      1 perl(Module::Install::Copyright) = 0.009
      1 perl(Module::Install::Credits) = 0.009
      1 perl-Module-Install-Copyright = 0.009-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-Module-Install-Copyright*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-06-29 13:00:42 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Module-Install-Copyright