Bug 1349859 - Review Request: perl-MooX-Struct - Record structure-like Moo classes
Summary: Review Request: perl-MooX-Struct - Record structure-like Moo classes
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1349524
Blocks: 1349910
TreeView+ depends on / blocked
 
Reported: 2016-06-24 11:52 UTC by Petr Pisar
Modified: 2016-06-28 13:26 UTC (History)
2 users (show)

Fixed In Version: perl-MooX-Struct-0.013-1.fc25
Clone Of:
Environment:
Last Closed: 2016-06-28 13:26:50 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-06-24 11:52:13 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-MooX-Struct/perl-MooX-Struct.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-MooX-Struct/perl-MooX-Struct-0.013-1.fc25.src.rpm
Description:
MooX::Struct allows you to create cheap struct-like classes for your data
using Moo.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-28 09:51:23 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MooX-Struct-0.013-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.8.0
      1 perl(B::Deparse)
      1 perl(B::Hooks::EndOfScope)
      1 perl(Carp) >= 0
      1 perl(Data::Dumper)
      1 perl(Data::OptList) >= 0
      1 perl(Data::Printer::Filter)
      1 perl(IO::Handle)
      1 perl(Moo) >= 1.000000
      1 perl(Moo::Role)
      1 perl(Object::ID) >= 0
      1 perl(Scalar::Does) >= 0
      1 perl(Sub::Install) >= 0
      1 perl(Term::ANSIColor)
      1 perl(namespace::clean)
      1 perl(overload)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-MooX-Struct-0.013-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(MooX::Struct) = 0.013
      1 perl(MooX::Struct::Processor) = 0.013
      1 perl(MooX::Struct::Util) = 0.013
      1 perl-MooX-Struct = 0.013-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-MooX-Struct*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-06-28 13:03:18 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MooX-Struct


Note You need to log in before you can comment on or make changes to this bug.