Bug 1351487
| Summary: | "Connection Address" and "Cancel" button in remote-viewer connection window have same access keys | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Xiaodai Wang <xiaodwan> | ||||||
| Component: | virt-viewer | Assignee: | Virt Viewer Maint <virt-viewer-maint> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 7.3 | CC: | dblechte, fidencio, juzhou, mxie, mzhan, rbalakri, tzheng, victortoso | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | virt-viewer-2.0-10.el7 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1351501 1351562 (view as bug list) | Environment: | |||||||
| Last Closed: | 2016-11-04 01:22:38 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1351501, 1351562 | ||||||||
| Attachments: |
|
||||||||
|
Description
Xiaodai Wang
2016-06-30 07:54:42 UTC
Patch is in the ML: https://www.redhat.com/archives/virt-tools-list/2016-June/msg00218.html Created attachment 1174415 [details]
a screen shot for connection window when pressing alt key.
And if press "alt+r", a warning displays in terminal. (remote-viewer:20535): Gtk-WARNING **: widget `GtkRecentChooserWidget' isn't suitable for mnemonic activation (In reply to xiaodwan from comment #3) > And if press "alt+r", a warning displays in terminal. > (remote-viewer:20535): Gtk-WARNING **: widget `GtkRecentChooserWidget' isn't > suitable for mnemonic activation "Mnemonics automatically activate any activatable widget the label is inside, such as a gtk.Button; if the label is not inside an activatable widget, you have to tell the label about the target using the set_mnemonic_widget() method. Here's a simple example where the label is inside a button." That's the definition of Mnemonics from Gtk+. alt+c is the mnemonic for Cancel and that's what my patch does. Add missig mnemonics for the buttons on that window. So, with the patch alt+c triggers the Cancel button, alt+o triggers the Connection button. Created attachment 1174428 [details]
Suitable downstream patches
I verified it with virt-viewer-2.0-10.el7.x86_64, "Connection Address" and "Cancel" button have different mnemonics, and their function work well. mnemonic of "Recent Connections" is removed. So move the bug from ON_QA to VERIFIED. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2229.html |