RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1351487 - "Connection Address" and "Cancel" button in remote-viewer connection window have same access keys
Summary: "Connection Address" and "Cancel" button in remote-viewer connection window h...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: virt-viewer
Version: 7.3
Hardware: x86_64
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Virt Viewer Maint
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 1351501 1351562
TreeView+ depends on / blocked
 
Reported: 2016-06-30 07:54 UTC by Xiaodai Wang
Modified: 2016-11-04 01:22 UTC (History)
8 users (show)

Fixed In Version: virt-viewer-2.0-10.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1351501 1351562 (view as bug list)
Environment:
Last Closed: 2016-11-04 01:22:38 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
a screen shot for connection window when pressing alt key. (18.66 KB, image/png)
2016-06-30 08:48 UTC, Xiaodai Wang
no flags Details
Suitable downstream patches (1.97 KB, application/mbox)
2016-06-30 09:29 UTC, Fabiano Fidêncio
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2229 0 normal SHIPPED_LIVE virt-viewer, libgovirt, spice-gtk, and usbredir bug fix and enhancement update 2016-11-03 13:26:58 UTC

Description Xiaodai Wang 2016-06-30 07:54:42 UTC
Description of problem:
"Connection Address" and "Cancel" button in remote-viewer connection window have same access keys

Version-Release number of selected component (if applicable):
virt-viewer-2.0-8.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Run "remote-viewer" interminal.
2. Press "alt" when connection window displays.
3. keep to press "alt+c" 

Actual results:
1. After step 2, "Connection Address" and "Cancel" button in remote-viewer connection window have same access keys
2. After step 3, The foucs switches betwen "Connection Address" and "Cancel" button. Can type some string when connection address text entry get foucus, but can't cancel the connection when "cancel" button get foucs.

Expected results:
"Connection Address" and "Cancel" button in remote-viewer connection window should have different access keys.

Additional info:

Comment 1 Fabiano Fidêncio 2016-06-30 08:10:23 UTC
Patch is in the ML:
https://www.redhat.com/archives/virt-tools-list/2016-June/msg00218.html

Comment 2 Xiaodai Wang 2016-06-30 08:48:27 UTC
Created attachment 1174415 [details]
a screen shot for connection window when pressing alt key.

Comment 3 Xiaodai Wang 2016-06-30 08:49:38 UTC
And if press "alt+r", a warning displays in terminal.
(remote-viewer:20535): Gtk-WARNING **: widget `GtkRecentChooserWidget' isn't 
suitable for mnemonic activation

Comment 4 Fabiano Fidêncio 2016-06-30 08:57:52 UTC
(In reply to xiaodwan from comment #3)
> And if press "alt+r", a warning displays in terminal.
> (remote-viewer:20535): Gtk-WARNING **: widget `GtkRecentChooserWidget' isn't 
> suitable for mnemonic activation

"Mnemonics automatically activate any activatable widget the label is inside, such as a gtk.Button; if the label is not inside an activatable widget, you have to tell the label about the target using the set_mnemonic_widget() method. Here's a simple example where the label is inside a button."

That's the definition of Mnemonics from Gtk+.

alt+c is the mnemonic for Cancel and that's what my patch does. Add missig mnemonics for the buttons on that window. So, with the patch alt+c triggers the Cancel button, alt+o triggers the Connection button.

Comment 5 Fabiano Fidêncio 2016-06-30 09:29:52 UTC
Created attachment 1174428 [details]
Suitable downstream patches

Comment 7 Xiaodai Wang 2016-07-04 07:11:56 UTC
I verified it with virt-viewer-2.0-10.el7.x86_64, 

"Connection Address" and "Cancel" button have different mnemonics, and their function work well.
mnemonic of "Recent Connections" is removed.

So move the bug from ON_QA to VERIFIED.

Comment 9 errata-xmlrpc 2016-11-04 01:22:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2229.html


Note You need to log in before you can comment on or make changes to this bug.