Bug 1351562

Summary: "Connection Address" and "Cancel" button in remote-viewer connection window have same access keys
Product: Red Hat Enterprise Linux 6 Reporter: Xiaodai Wang <xiaodwan>
Component: virt-viewerAssignee: Eduardo Lima (Etrunko) <elima>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 6.9CC: cfergeau, dblechte, elima, fidencio, juzhou, mxie, mzhan, pgrunt, rbalakri, tzheng, virt-bugs, virt-viewer-maint
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-viewer-2.0-15.el6 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1351487 Environment:
Last Closed: 2017-03-21 09:19:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1351487    
Bug Blocks: 1351501    

Description Xiaodai Wang 2016-06-30 10:33:51 UTC
+++ This bug was initially created as a clone of Bug #1351487 +++

Description of problem:
"Connection Address" and "Cancel" button in remote-viewer connection window have same access keys

Version-Release number of selected component (if applicable):
virt-viewer-2.0-8.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Run "remote-viewer" interminal.
2. Press "alt" when connection window displays.
3. keep to press "alt+c" 

Actual results:
1. After step 2, "Connection Address" and "Cancel" button in remote-viewer connection window have same access keys
2. After step 3, The foucs switches betwen "Connection Address" and "Cancel" button. Can type some string when connection address text entry get foucus, but can't cancel the connection when "cancel" button get foucs.

Expected results:
"Connection Address" and "Cancel" button in remote-viewer connection window should have different access keys.

Additional info:

--- Additional comment from Fabiano FidĂȘncio on 2016-06-30 04:10:23 EDT ---

Patch is in the ML:
https://www.redhat.com/archives/virt-tools-list/2016-June/msg00218.html

--- Additional comment from  on 2016-06-30 04:48 EDT ---



--- Additional comment from  on 2016-06-30 04:49:38 EDT ---

And if press "alt+r", a warning displays in terminal.
(remote-viewer:20535): Gtk-WARNING **: widget `GtkRecentChooserWidget' isn't 
suitable for mnemonic activation

--- Additional comment from Fabiano FidĂȘncio on 2016-06-30 04:57:52 EDT ---

(In reply to xiaodwan from comment #3)
> And if press "alt+r", a warning displays in terminal.
> (remote-viewer:20535): Gtk-WARNING **: widget `GtkRecentChooserWidget' isn't 
> suitable for mnemonic activation

"Mnemonics automatically activate any activatable widget the label is inside, such as a gtk.Button; if the label is not inside an activatable widget, you have to tell the label about the target using the set_mnemonic_widget() method. Here's a simple example where the label is inside a button."

That's the definition of Mnemonics from Gtk+.

alt+c is the mnemonic for Cancel and that's what my patch does. Add missig mnemonics for the buttons on that window. So, with the patch alt+c triggers the Cancel button, alt+o triggers the Connection button.

--- Additional comment from Fabiano FidĂȘncio on 2016-06-30 05:29 EDT ---

Comment 4 Xiaodai Wang 2016-12-05 07:25:49 UTC
I verified it with virt-viewer-2.0-17.el6.x86_64:

"Connection Address" and "Cancel" button have different mnemonics, and their function work well.
mnemonic of "Recent Connections" is removed.

So move the bug from ON_QA to VERIFIED.

Comment 6 errata-xmlrpc 2017-03-21 09:19:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0587.html