Bug 1351711
| Summary: | build: remove absolute paths from glusterfs spec file | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Kaleb KEITHLEY <kkeithle> |
| Component: | build | Assignee: | Kaleb KEITHLEY <kkeithle> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.8.0 | CC: | bugs, mchangir, ndevos, rhs-bugs, storage-qa-internal |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.8.1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1350793 | Environment: | |
| Last Closed: | 2016-07-08 14:42:35 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1350793 | ||
| Bug Blocks: | 1350745 | ||
|
Comment 1
Vijay Bellur
2016-06-30 15:57:02 UTC
REVIEW: http://review.gluster.org/14837 (build: glusterfs.spec(.in) firewalld file doesn't use %{_prefix}) posted (#2) for review on release-3.8 by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/14837 (build: glusterfs.spec(.in) firewalld file doesn't use %{_prefix}) posted (#3) for review on release-3.8 by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/14837 committed in release-3.8 by Niels de Vos (ndevos) ------ commit 244decb1cc6091d441a58bcc5f9f7f85291a2f09 Author: Kaleb S KEITHLEY <kkeithle> Date: Thu Jun 30 11:53:51 2016 -0400 build: glusterfs.spec(.in) firewalld file doesn't use %{_prefix} .../firewalld/services/glusterfs.xml in %server files section does not use %{_prefix} Other firewalld files, e.g., in the firewalld.src.rpm file use %{_prefix} N.B. the other 'hardcoded' path, "/sbin/mount.glusterfs" in the %files fuse section must remain as is, there is no macro for mount utilities to use as there is for, e.g., the %{_sbindir} macro for /usr/sbin. This doesn't matter for either RHEL6, where /sbin and /usr/sbin are distinct directories, or for Fedora and RHEL7, where /sbin is a symlink to /usr/sbin. E.g. see the nfs- utils.src.rpm where /sbin/mount.nfs is also 'hardcoded' Backport of commit c4ddfa5b76690db66fb22518d12226e2bf9cb236: > Change-Id: I902f47e3c589526c774d0aceb6fc2815abf86b01 > BUG: 1350793 > Signed-off-by: Kaleb S KEITHLEY <kkeithle> > Reviewed-on: http://review.gluster.org/14823 > Smoke: Gluster Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> > NetBSD-regression: NetBSD Build System <jenkins.org> > Reviewed-by: Milind Changire <mchangir> > Reviewed-by: Niels de Vos <ndevos> Change-Id: I902f47e3c589526c774d0aceb6fc2815abf86b01 BUG: 1351711 Signed-off-by: Kaleb S KEITHLEY <kkeithle> Reviewed-on: http://review.gluster.org/14837 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> Smoke: Gluster Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.1, please open a new bug report. glusterfs-3.8.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/156 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |