Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1350793

Summary:	build: remove absolute paths from glusterfs spec file
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	build	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, mchangir, ndevos, rhs-bugs, storage-qa-internal
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1350745
Clones:	1351711 (view as bug list)		Environment:
Last Closed:	2016-12-06 05:14:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1350745, 1351711

Comment 1 Vijay Bellur 2016-06-28 19:01:09 UTC

REVIEW: http://review.gluster.org/14823 (build: glusterfs.spec(.in) firewalld file doesn't use %{_prefix}) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Vijay Bellur 2016-06-30 15:46:08 UTC

COMMIT: http://review.gluster.org/14823 committed in master by Niels de Vos (ndevos) 
------
commit c4ddfa5b76690db66fb22518d12226e2bf9cb236
Author: Kaleb S KEITHLEY <kkeithle>
Date:   Tue Jun 28 14:48:14 2016 -0400

    build: glusterfs.spec(.in) firewalld file doesn't use %{_prefix}
    
    .../firewalld/services/glusterfs.xml in %server files section
    does not use %{_prefix}
    
    Other firewalld files, e.g., in the firewalld.src.rpm file use
    %{_prefix}
    
    N.B. the other 'hardcoded' path, "/sbin/mount.glusterfs" in the
    %files fuse section must remain as is, there is no macro for
    mount utilities to use as there is for, e.g., the %{_sbindir}
    macro for /usr/sbin. This doesn't matter for either RHEL6, where
    /sbin and /usr/sbin are distinct directories, or for Fedora and
    RHEL7, where /sbin is a symlink to /usr/sbin. E.g. see the nfs-
    utils.src.rpm where /sbin/mount.nfs is also 'hardcoded'.
    
    Change-Id: I902f47e3c589526c774d0aceb6fc2815abf86b01
    BUG: 1350793
    Signed-off-by: Kaleb S KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/14823
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Milind Changire <mchangir>
    Reviewed-by: Niels de Vos <ndevos>