Bug 1352714
| Summary: | Review Request: soup-sharp - libsoup C# bindings | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kyle J. Harms <kyle.harms> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | comzeradd, dustymabe, package-review, zebob.m |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-10 21:58:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Kyle J. Harms
2016-07-04 21:03:37 UTC
Review swap with bug #1321473? Review swap with bug #1279093? > Requires: %{name} = %{version}-%{release} missing %{?_isa} > Requires: pkgconfig not needed > %setup -q > %autosetup only one should be choosen > make not %{_smp_mflags}, better to use %make_build > make DESTDIR=%{buildroot} install can be %make_install > %{_libdir}/libsoupsharpglue-2.42.2.so 2.42.2 -> %{version} > %{_libdir}/libsoupsharpglue*.la libtool files should not be packaged > %{_libdir}/libsoupsharpglue*.a static libraries should not be packaged or can be packaged to special -static subpkg (but I don't recommend to do this) > Source0: https://github.com/stsundermann/%{name}/archive/%{version}.zip#/%{name}-%{version}.tar.gz .zip -> .tar.gz something wrong here. also you canuse %{url} instead of https://github.com.... until /archive so, not ready ;) * Missing BuildRequires for compiler.. Thanks for the review. I think I have addressed everything. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/harmsk/sparkleshare/soup-sharp.git/plain/soup-sharp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/harmsk/sparkleshare/fedora-rawhide-x86_64/00389463-soup-sharp/soup-sharp-2.42.2-4.fc25.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14928668 You should consider joining the mono SIG. Are you interested in doing more reviews for mono packages? https://fedoraproject.org/wiki/SIGs/Mono Dusty, why did you set needinfo? I just commented this request to provide my opinion. Hey Igor, It looked like you were doing the review and Kyle was trying to address your comments so I thought he was waiting on feedback from you to finish the review. (In reply to Kyle J. Harms from comment #4) > Thanks for the review. I think I have addressed everything. > > Spec URL: > http://copr-dist-git.fedorainfracloud.org/cgit/harmsk/sparkleshare/soup- > sharp.git/plain/soup-sharp.spec > SRPM URL: > https://copr-be.cloud.fedoraproject.org/results/harmsk/sparkleshare/fedora- > rawhide-x86_64/00389463-soup-sharp/soup-sharp-2.42.2-4.fc25.src.rpm > Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14928668 Bumpity-bump, I need soup-sharp packaged too. Are you willing to continue with it? I can comaintain and sponsor you? - Drop: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig It is not not needed anymore Maybe package the latest GIT master as it contains minor fixes to the pkgconfig - Remove: Group: Development/Libraries It is not needed in Fedora. - Use: Source0: https://github.com/stsundermann/%{name}/archive/%{version}/%{name}-%{version}.tar.gz As I said I can sponsor and comaintain, if you're still interested in Fedora. If no answer within one week, I'll close the bug and package on my own. |