Spec URL: http://research.engineering.wustl.edu/~harmsk/downloads/fedora/soup-sharp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/harmsk/sparkleshare/fedora-rawhide-x86_64/00366213-soup-sharp/soup-sharp-2.42.2-3.fc25.src.rpm Description: C# bindings for libsoup2.4 Fedora Account System Username: harmsk I was contacted the maintainer of the sparkleshare package, Nikos Roussos, if I would be interested in maintaining two of the dependencies for sparkleshare. I had setup these builds on copr for these dependencies, https://copr.fedorainfracloud.org/coprs/harmsk/sparkleshare/ Because this is my first package, I'm seeking a sponsor. Successful koji build, http://koji.fedoraproject.org/koji/taskinfo?taskID=14767677
Review swap with bug #1321473?
Review swap with bug #1279093?
> Requires: %{name} = %{version}-%{release} missing %{?_isa} > Requires: pkgconfig not needed > %setup -q > %autosetup only one should be choosen > make not %{_smp_mflags}, better to use %make_build > make DESTDIR=%{buildroot} install can be %make_install > %{_libdir}/libsoupsharpglue-2.42.2.so 2.42.2 -> %{version} > %{_libdir}/libsoupsharpglue*.la libtool files should not be packaged > %{_libdir}/libsoupsharpglue*.a static libraries should not be packaged or can be packaged to special -static subpkg (but I don't recommend to do this) > Source0: https://github.com/stsundermann/%{name}/archive/%{version}.zip#/%{name}-%{version}.tar.gz .zip -> .tar.gz something wrong here. also you canuse %{url} instead of https://github.com.... until /archive so, not ready ;) * Missing BuildRequires for compiler..
Thanks for the review. I think I have addressed everything. Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/harmsk/sparkleshare/soup-sharp.git/plain/soup-sharp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/harmsk/sparkleshare/fedora-rawhide-x86_64/00389463-soup-sharp/soup-sharp-2.42.2-4.fc25.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14928668
You should consider joining the mono SIG. Are you interested in doing more reviews for mono packages? https://fedoraproject.org/wiki/SIGs/Mono
Dusty, why did you set needinfo? I just commented this request to provide my opinion.
Hey Igor, It looked like you were doing the review and Kyle was trying to address your comments so I thought he was waiting on feedback from you to finish the review.
(In reply to Kyle J. Harms from comment #4) > Thanks for the review. I think I have addressed everything. > > Spec URL: > http://copr-dist-git.fedorainfracloud.org/cgit/harmsk/sparkleshare/soup- > sharp.git/plain/soup-sharp.spec > SRPM URL: > https://copr-be.cloud.fedoraproject.org/results/harmsk/sparkleshare/fedora- > rawhide-x86_64/00389463-soup-sharp/soup-sharp-2.42.2-4.fc25.src.rpm > Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14928668 Bumpity-bump, I need soup-sharp packaged too. Are you willing to continue with it? I can comaintain and sponsor you? - Drop: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig It is not not needed anymore Maybe package the latest GIT master as it contains minor fixes to the pkgconfig - Remove: Group: Development/Libraries It is not needed in Fedora. - Use: Source0: https://github.com/stsundermann/%{name}/archive/%{version}/%{name}-%{version}.tar.gz As I said I can sponsor and comaintain, if you're still interested in Fedora. If no answer within one week, I'll close the bug and package on my own.