Bug 1352974
| Summary: | virt-manager still uses gtk-cancel which is deprecated in GTK3 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] Virtualization Tools | Reporter: | Laurent Bigonville <bigon> | ||||
| Component: | virt-manager | Assignee: | Cole Robinson <crobinso> | ||||
| Status: | CLOSED UPSTREAM | QA Contact: | |||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | unspecified | CC: | berrange, bigon, crobinso, gscrivan, pachoramos1, rbalakri | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-08-03 17:06:44 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Laurent Bigonville
2016-07-05 16:02:48 UTC
And actually all the gtk-* icons are deprecated now Thanks for the report. gtk3 stock icon names are deprecated but my understanding was that they won't be removed until gtk4, like all other APIs deprecated during the gtk3 cycle. And in latest gtk git gtk/icons/22x22/actions/gtk-cancel.png is still present, which is where the Adwaita icon theme is tracked AFAIK. What distro is this? What gtk versions are you using? I'm using debian unstable (with gtk 3.20). I also just tried with Fedora 24 (livecd) and the gtk-cancel.png is not present in the Adwaita theme (default theme for gtk3). If you go to the connection details the "Stop" icon is different between the storage/interface and virtual network tabs The documentation contains hints about the new icons name to use: https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-CANCEL:CAPS https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-STOP:CAPS Created attachment 1304113 [details]
Patch
Thanks for the patch! I've pushed it now |