Bug 1352974 - virt-manager still uses gtk-cancel which is deprecated in GTK3
Summary: virt-manager still uses gtk-cancel which is deprecated in GTK3
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-05 16:02 UTC by Laurent Bigonville
Modified: 2017-08-03 17:06 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-08-03 17:06:44 UTC
Embargoed:

Attachments (Terms of Use)
Patch (1.64 KB, patch)
2017-07-25 09:14 UTC, Laurent Bigonville 		no flags Details | Diff
View All

Description Laurent Bigonville 2016-07-05 16:02:48 UTC 
Hi,

virt-manager still uses gtk-cancel which is deprecated in GTK3

This is not present in the adwaita icon theme (default for GTK3) and should probably be replaced by something else
Comment 1 Laurent Bigonville 2016-07-05 16:18:44 UTC 
And actually all the gtk-* icons are deprecated now
Comment 2 Cole Robinson 2016-07-13 18:06:17 UTC 
Thanks for the report. gtk3 stock icon names are deprecated but my understanding was that they won't be removed until gtk4, like all other APIs deprecated during the gtk3 cycle. And in latest gtk git gtk/icons/22x22/actions/gtk-cancel.png is still present, which is where the Adwaita icon theme is tracked AFAIK.

What distro is this? What gtk versions are you using?
Comment 3 Laurent Bigonville 2016-07-14 10:13:31 UTC 
I'm using debian unstable (with gtk 3.20).

I also just tried with Fedora 24 (livecd) and the gtk-cancel.png is not present in the Adwaita theme (default theme for gtk3).

If you go to the connection details the "Stop" icon is different between the storage/interface and virtual network tabs

The documentation contains hints about the new icons name to use:

https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-CANCEL:CAPS

https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-STOP:CAPS
Comment 4 Laurent Bigonville 2017-07-25 09:14:21 UTC 
Created attachment 1304113 [details]
Patch
Comment 5 Cole Robinson 2017-08-03 17:06:44 UTC 
Thanks for the patch! I've pushed it now
Note You need to log in before you can comment on or make changes to this bug.