Bug 1352997
| Summary: | Review Request: gns3-net-converter - Convert old ini-style GNS3 topologies to v1+ JSON format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Othman Madjoudj <athmanem> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alekcejk, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-18 03:52:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1353001 | ||
|
Description
Othman Madjoudj
2016-07-05 17:40:56 UTC
In all three packages, it would be better to add some kind of tests in %check. For example in this package you could add a simple package in the old format and convert it in %check to see that the executables work as expected.
gns3-net-converter.noarch: W: incoherent-version-in-changelog 1.5.0-1 ['1.3.0-1.fc24', '1.3.0-1']
"-n %{name}-%{version}" is the default, it can be removed.
%description should end in a dot.
+ package name is OK
+ latest version
+ python packaging template is used
+ rpmlint is happy (module the warning above)
+ no scriptlets present or necessary
+ %description is legible
You package does not have any python Provides. This means that other packages cannot depend on the gns3converter python module. I don't know if that would actually be possible, that is if the module can be used externally. I guess it's OK to leave things as they are for now.
Package is APPROVED. Please fix the small issues listed at the top, and consider adding %check.
Oh, Summary is wrong. Please fix, in the spec file and in the title of this ticket. Sorry for copy-paste mess. Here's the new spec/srpm, thanks alot for reviewing. Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/gns3-net-converter.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/gns3-net-converter-1.3.0-2.fc24.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gns3-net-converter gns3-gui-1.5.1-2.fc24 gns3-server-1.5.1-1.fc24 gns3-net-converter-1.3.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b0b7e1057b gns3-gui-1.5.1-2.fc24, gns3-net-converter-1.3.0-2.fc24, gns3-server-1.5.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b0b7e1057b gns3-gui-1.5.1-2.fc24, gns3-net-converter-1.3.0-2.fc24, gns3-server-1.5.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |