Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/gns3-gui.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/gns3-gui-1.5.0-1.fc24.src.rpm Description: GNS3 is a graphical network simulator that allows you to design complex network topologies. You may run simulations or configure devices ranging from simple workstations to powerful routers. This package is for the client (GUI). Fedora Account System Username: athmane
Since this is a GUI tool, an appdata file is strongly recommended [ https://fedoraproject.org/wiki/Packaging:AppData]. Please split the Requires and BuildRequires into one-per-line. "This package is for the client (GUI)." → "This package contains the client graphical user interface." -exec rm -f {} \; → -delete https://bugzilla.redhat.com/show_bug.cgi?id=1353000#c6 also applies here.
Hm, I built the package, but gns3-net-converter is missing.
Oh, OK, I see it's also under review.
Summary is wrong, please fix it in the spec file and in the title of this ticket.
Thank you for reviewing, please find the new spec/srpm. I forgot to mention that I'm building this on copr (dnf copr enable athmane/gns3) Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/gns3-gui.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/gns3-gui-1.5.1-1.fc24.src.rpm %changelog * Tue Aug 02 2016 Athmane Madjoudj <athmane> - 1.5.1-1 - Update to 1.5.1 - Fix the url * Tue Aug 02 2016 Athmane Madjoudj <athmane> - 1.5.0-2 - Minor spec fixes - Provide AppData
+ package name is OK + latest version + license is acceptable - license is specified correctly: the license is GPLv3+, not GPLv3, according to headers + no scriptlets present or necessary - appdata file is present (but see below) + package builds and installs OK + provides/requires look sane Package is APPROVED, please fix up when uploading. -- appstream-util validate says: • tag-invalid : <metadata_license> is not valid [GPLv3] • tag-invalid : <project_license> is not valid [GPLv3]SPDX ID 'GPLv3' unknown Correct spdx tag is GPL-3.0+ • tag-missing : <translation> not specified • tag-missing : <update_contact> is not present You should probably use your maintainer e-mail here. • style-invalid : Not enough <screenshot> tags Without screenshots the package looks bad in gnome-software :( • tag-missing : <name> is not present • tag-missing : <summary> is not present Those two should be added. It would be nice to fix the appdata file to also pass validate without warnings (%check should continue to use validate-relax --nonet).
Oh, and <metadata_license> should be CC0-1.0, just to make life easier for everybody.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gns3-gui
Appdata fixed (got only warning about translation and screenshot being small), I used before gvim as a starting point which seem a bit off. Thanks a lot for reviewing.
gns3-gui-1.5.1-2.fc24 gns3-server-1.5.1-1.fc24 gns3-net-converter-1.3.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b0b7e1057b
gns3-gui-1.5.1-2.fc24, gns3-net-converter-1.3.0-2.fc24, gns3-server-1.5.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b0b7e1057b
gns3-gui-1.5.1-2.fc24, gns3-net-converter-1.3.0-2.fc24, gns3-server-1.5.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.