Bug 1353119

Summary: API protocol change in vdsm
Product: Red Hat Enterprise Linux 7 Reporter: Piotr Kliczewski <pkliczew>
Component: virt-whoAssignee: Chris Snyder <csnyder>
Status: CLOSED CURRENTRELEASE QA Contact: Eko <hsun>
Severity: medium Docs Contact:
Priority: high    
Version: 7.3CC: csnyder, danken, hsun, jherrman, mkalinin, mperina, pkliczew, salmy, spower, yuefliu
Target Milestone: rcKeywords: Triaged, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-who-0.21.4-1 Doc Type: Bug Fix
Doc Text:
Previously, the virt-who utility did not work with certain versions of the Red Hat Virtualization suite. This update enhances virt-who to support the JSON-RPC over STOMP communication protocol, which prevents the described problem from occurring.
Story Points: ---
Clone Of:
: 1540296 (view as bug list) Environment:
Last Closed: 2018-10-10 20:43:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1527284, 1540296    

Description Piotr Kliczewski 2016-07-06 07:21:06 UTC
Currently virt-who uses xmlrpc to talk to vdsm. This protocol is deprecated and it is about to be removed. Please migrate to new jsonrpc.

Comment 2 Radek Novacek 2016-07-12 11:26:09 UTC
Piotr, when will the XMLRPC API stop working? Is there a documentation of the new jsonrpc API? Or at least some existing code to start with? Thanks.

Comment 3 Piotr Kliczewski 2016-07-25 12:50:04 UTC
We do not have any date specified yet. At the moment we are migrating our code base to jsonrpc. Hopefully it will be done as part of 4.1 release.

Comment 4 Piotr Kliczewski 2016-07-25 12:54:10 UTC
You can find an example of the change here [1]. The code creates jsonrpc client to migrate vms if it fails it falls back to xmlrpc.



[1] https://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob;f=vdsm/virt/migration.py;h=c4cb10756a610752708f1049e14cb9fbdb20af36;hb=refs/heads/master

Comment 5 Chris Snyder 2016-12-22 18:18:28 UTC
*** Bug 1402853 has been marked as a duplicate of this bug. ***

Comment 6 Piotr Kliczewski 2017-01-02 08:19:53 UTC
We improved the client please take a look at [1]


[1] https://github.com/oVirt/vdsm/blob/master/lib/vdsmclient/client.py

Comment 7 Chris Snyder 2017-06-14 19:19:27 UTC
Piotr

Do you have any update regarding when the XMLRPC api will stop working?

Thank you for the link to the updated client.

Cheers,
Chris

Comment 8 Piotr Kliczewski 2017-06-14 19:20:45 UTC
It was removed few weeks ago and will be released as part of 4.2.

Comment 9 Yaniv Kaul 2017-06-14 21:34:18 UTC
(In reply to Piotr Kliczewski from comment #8)
> It was removed few weeks ago and will be released as part of 4.2.

The new client is already available since 4.1 (released already).

Comment 10 Martin Perina 2017-12-21 10:05:10 UTC
RHV 4.2 and RHEL 7.5 releases are very close to each other, so RHV 4.2 will need to support both RHEL 7.5 and 7.4.z

Comment 25 Marina Kalinin 2018-10-10 20:43:34 UTC
Fixed in RHEL 7.5 - virt-who-0.21.5-1.el7.