Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1527284

Summary:	Failed to run virt-who for VDSM4.20.9.2 with ProtocolError
Product:	[oVirt] vdsm	Reporter:	yuefliu <yuefliu>
Component:	Services	Assignee:	Martin Perina <mperina>
Status:	CLOSED CURRENTRELEASE	QA Contact:	yuefliu <yuefliu>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	4.20.9.2	CC:	bugs, csnyder, hsun, lsvaty, mperina, pstehlik, yuefliu
Target Milestone:	ovirt-4.2.2	Keywords:	Regression, TestOnly
Target Release:	4.20.17	Flags:	rule-engine: ovirt-4.2+ rule-engine: blocker+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	v4.20.17	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-10 06:23:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1353119
Bug Blocks:

Comment 3 Yaniv Bronhaim 2017-12-20 10:02:16 UTC

virt-who still uses xmlrpc requests to vdsm -
https://github.com/virt-who/virt-who/blob/master/virtwho/virt/vdsm/vdsm.py#L125

In vdsm log you can see now: 

2017-12-20 11:57:12,377+0200 INFO  (Reactor thread) [ProtocolDetector.AcceptorImpl] Accepted connection from ::ffff:10.35.16.144:60842 (protocoldetector:61)
2017-12-20 11:57:12,389+0200 DEBUG (Reactor thread) [ProtocolDetector.Detector] Using required_size=11 (protocoldetector:89)
2017-12-20 11:57:12,390+0200 WARN  (Reactor thread) [ProtocolDetector.Detector] Unrecognized protocol: 'POST /RPC2 ' (protocoldetector:132)
2017-12-20 11:57:12,390+0200 DEBUG (Reactor thread) [root] inside asyncore.dispatcher.close (asyncore:413)
2017-12-20 11:57:12,390+0200 DEBUG (Reactor thread) [root] deleting channel (asyncore:417)
2017-12-20 11:57:12,390+0200 DEBUG (Reactor thread) [root] deleting channel (asyncore:295)
2017-12-20 11:57:12,391+0200 DEBUG (Reactor thread) [root] closing socket (asyncore:420)

This is new in 4.2, 4.1 vdsm still replies to such those requests.

In #1353119 we already requested to use vdsm new client - https://github.com/oVirt/vdsm/blob/master/lib/vdsmclient/client.py

Comment 4 Eko 2017-12-21 07:57:39 UTC

Hi Chris, 
As comment3, the VDSM API protocol is changed from vdsm-4.20, I'm afraid we need to change some virt-who functions for vdsm4.1x and 4.2x compatibility.

Comment 5 Eko 2017-12-21 07:59:14 UTC

Hi Yaniv Bronhaim,
rhev-4.2 is based on RHEL7.4 or 7.5? 
if 7.4, I think we should create a z-stream build for virt-who to fix the new API issue.
if 7.5, the new API may be supported by virt-who when RHEL7.5 GA version is available.

Comment 6 Martin Perina 2017-12-21 09:59:21 UTC

(In reply to Eko from comment #5)
> Hi Yaniv Bronhaim,
> rhev-4.2 is based on RHEL7.4 or 7.5? 
> if 7.4, I think we should create a z-stream build for virt-who to fix the
> new API issue.
> if 7.5, the new API may be supported by virt-who when RHEL7.5 GA version is
> available.

Hi,

unfortunately releases of RHV 4.2 GA and RHEL 7.5 are very close to each other, so we will need the fix to be included in both 7.4.z and 7.5.

Thanks

Comment 7 Red Hat Bugzilla Rules Engine 2018-01-07 12:52:58 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 11 Martin Perina 2018-02-05 18:16:12 UTC

Moving to MODIFIED as virt-who has already been fixed:

RHEL 7.4.z:
  - tracked by BZ1540296
  - fixed in virt-who-0.19-8

RHEL 7.5:
  - tracked by BZ1353119
  - fixed in virt-who-0.21.4-1

Comment 14 Martin Perina 2018-02-15 11:53:25 UTC

Based on above moving to ON_QA

Comment 19 Sandro Bonazzola 2018-05-10 06:23:56 UTC

This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.