Bug 1354260

Summary:	quota : rectify quota-deem-statfs default value in gluster v set help command
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Manikandan <mselvaga>
Component:	quota	Assignee:	Raghavendra G <rgowdapp>
Status:	CLOSED ERRATA	QA Contact:	Anil Shah <ashah>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.1	CC:	amukherj, bugs, rcyriac, rhinduja, rhs-bugs, smohan
Target Milestone:	---	Keywords:	EasyFix, Triaged
Target Release:	RHGS 3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.4-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1345846	Environment:
Last Closed:	2017-03-23 05:39:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1345846
Bug Blocks:	1346134, 1346184, 1351522

Description Manikandan 2016-07-11 05:21:58 UTC

+++ This bug was initially created as a clone of Bug #1345846 +++

Description of problem:
quota-deem-statfs volume option is on by default. But the volume set option shows off as default value.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. gluster v set help | grep quota


Actual results:
Option: features.quota-deem-statfs
Description: If set to on, it takes quota limits intoconsideration while estimating fs size. (df command) (Default is off).


Expected results:
Option: features.quota-deem-statfs
Description: If set to on, it takes quota limits intoconsideration while estimating fs size. (df command) (Default is on).



Additional info:

--- Additional comment from Vijay Bellur on 2016-06-13 06:16:53 EDT ---

REVIEW: http://review.gluster.org/14708 (quota : rectify quota-deem-statfs default settings) posted (#2) for review on master by Manikandan Selvaganesh (mselvaga)

--- Additional comment from Vijay Bellur on 2016-06-14 01:51:33 EDT ---

COMMIT: http://review.gluster.org/14708 committed in master by Raghavendra G (rgowdapp) 
------
commit c158742fb52ae1f6d3576c64caf42b67d784a3e3
Author: Manikandan Selvaganesh <mselvaga>
Date:   Mon Jun 13 15:28:41 2016 +0530

    quota : rectify quota-deem-statfs default settings
    
    Change-Id: I75c47c4a0f0eb898b5e32efe7f0a6a558d7f8007
    BUG: 1345846
    Signed-off-by: Manikandan Selvaganesh <mselvaga>
    Reviewed-on: http://review.gluster.org/14708
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 2 Manikandan 2016-08-02 10:11:54 UTC

Upstream patch:
master: http://review.gluster.org/#/c/14708/
3.8: http://review.gluster.org/#/c/14726/

Comment 4 Atin Mukherjee 2016-09-17 13:16:35 UTC

Upstream mainline : http://review.gluster.org/14708
Upstream 3.8 : http://review.gluster.org/14726

And the fix is available in rhgs-3.2.0 as part of rebase to GlusterFS 3.8.4.

Comment 9 Anil Shah 2016-11-03 05:58:58 UTC

[root@rhs-client46 ~]# gluster v set help | grep quota
Option: features.quota-deem-statfs
Description: If set to on, it takes quota limits into consideration while estimating fs size. (df command) (Default is on).

Bug verified on build glusterfs-3.8.4-3.el7rhgs.x86_64

Comment 11 errata-xmlrpc 2017-03-23 05:39:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2017-0486.html