Bug 1357050

Summary:	exit codes don't match error messages in firewall-cmd
Product:	Red Hat Enterprise Linux 7	Reporter:	Tomas Dolezal <todoleza>
Component:	firewalld	Assignee:	Thomas Woerner <twoerner>
Status:	CLOSED ERRATA	QA Contact:	Tomas Dolezal <todoleza>
Severity:	high	Docs Contact:
Priority:	high
Version:	7.2	CC:	todoleza
Target Milestone:	rc	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	firewalld-0.4.3.2-2.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-03 21:03:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Dolezal 2016-07-15 15:06:34 UTC

Description of problem:
error message and exit code of firewall-cmd does not match

Version-Release number of selected component (if applicable):
firewalld-0.4.3.2-1.el7.noarch

How reproducible:
always

Steps to Reproduce:
[root@vm-rhel7s ~]# firewall-cmd --add-rich-rule 'rule family=ipv4 service name=dns limit value=4/d accept' --zone inexistent_zone; echo EC=$?
Error: INVALID_ZONE: inexistent_zone
EC=254

[root@vm-rhel7s ~]# firewall-cmd --add-rich-rule 'rule family=ipv4 service name=dns limit value=1/d accept' ; echo EC=$?
Error: INVALID_LIMIT: 1/d too slow
EC=254

Actual results:
bad exitcodes: 254 ~ UNKNOWN

Expected results:
exitcodes are according to manpage and the name of the error

Additional info:

Comment 3 Thomas Woerner 2016-07-15 17:22:40 UTC

Fixed upstream: https://github.com/t-woerner/firewalld/commit/449be745f0b7e43f54fdbab9f19873a64ca73a8f

Comment 7 errata-xmlrpc 2016-11-03 21:03:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2597.html