Bug 1357050 – exit codes don't match error messages in firewall-cmd

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1357050 - exit codes don't match error messages in firewall-cmd

Summary:	exit codes don't match error messages in firewall-cmd

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	firewalld (Show other bugs)
Sub Component:
Version:	7.2
Hardware:	Unspecified Unspecified

Priority	high Severity high
Target Milestone:	rc
Target Release:	---
Assigned To:	Thomas Woerner
QA Contact:	Tomas Dolezal
Docs Contact:

URL:
Whiteboard:
Keywords:	Regression

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-07-15 11:06 EDT by Tomas Dolezal
Modified:	2016-11-03 17:03 EDT (History)
CC List:	1 user (show)

See Also:
Fixed In Version:	firewalld-0.4.3.2-2.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-11-03 17:03:17 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2016:2597	normal	SHIPPED_LIVE	Moderate: firewalld security, bug fix, and enhancement update	2016-11-03 08:11:47 EDT

Groups: None (edit)

Description Tomas Dolezal 2016-07-15 11:06:34 EDT

Description of problem:
error message and exit code of firewall-cmd does not match

Version-Release number of selected component (if applicable):
firewalld-0.4.3.2-1.el7.noarch

How reproducible:
always

Steps to Reproduce:
[root@vm-rhel7s ~]# firewall-cmd --add-rich-rule 'rule family=ipv4 service name=dns limit value=4/d accept' --zone inexistent_zone; echo EC=$?
Error: INVALID_ZONE: inexistent_zone
EC=254

[root@vm-rhel7s ~]# firewall-cmd --add-rich-rule 'rule family=ipv4 service name=dns limit value=1/d accept' ; echo EC=$?
Error: INVALID_LIMIT: 1/d too slow
EC=254

Actual results:
bad exitcodes: 254 ~ UNKNOWN

Expected results:
exitcodes are according to manpage and the name of the error

Additional info:

Comment 3 Thomas Woerner 2016-07-15 13:22:40 EDT

Fixed upstream: https://github.com/t-woerner/firewalld/commit/449be745f0b7e43f54fdbab9f19873a64ca73a8f

Comment 7 errata-xmlrpc 2016-11-03 17:03:17 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2597.html

Note You need to log in before you can comment on or make changes to this bug.