Bug 1358921

Summary: editing commit message through gerrit's web interface does not work anymore
Product: [Community] GlusterFS Reporter: Vijay Bellur <vbellur>
Component: project-infrastructureAssignee: Nigel Babu <nigelb>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, gluster-infra, nigelb
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-02 03:02:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vijay Bellur 2016-07-21 19:08:00 UTC
Description of problem:

Sometime back editing a git commit message in gerrit was possible. Recently it cannot be done. Would it be possible to fix this? Thanks!

Comment 1 Nigel Babu 2016-07-22 04:39:09 UTC
You still can. Gerrit removed the "Edit Commit Message" button a long time ago. To edit the commit message you need to select the checkbox next to "Commit Messsage" and press "Edit". This will cause flags to be cleared though.

I can look at ensuring the flags don't get cleared when you do this.

Comment 2 Vijay Bellur 2016-07-23 02:46:40 UTC
(In reply to Nigel Babu from comment #1)
> You still can. Gerrit removed the "Edit Commit Message" button a long time
> ago. To edit the commit message you need to select the checkbox next to
> "Commit Messsage" and press "Edit". This will cause flags to be cleared
> though.
> 

Thanks! I was able to edit the commit message through this process.

> I can look at ensuring the flags don't get cleared when you do this.

This would be great to have.

Comment 3 Nigel Babu 2016-08-02 03:02:52 UTC
The flags already don't get cleared. We used to clear the Verified flag. I've changed it so that you retain them for commit changes and no-change rebases.