Bug 1358921 - editing commit message through gerrit's web interface does not work anymore
Summary: editing commit message through gerrit's web interface does not work anymore
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nigel Babu
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-21 19:08 UTC by Vijay Bellur
Modified: 2016-08-02 03:02 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-08-02 03:02:52 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Vijay Bellur 2016-07-21 19:08:00 UTC
Description of problem:

Sometime back editing a git commit message in gerrit was possible. Recently it cannot be done. Would it be possible to fix this? Thanks!

Comment 1 Nigel Babu 2016-07-22 04:39:09 UTC
You still can. Gerrit removed the "Edit Commit Message" button a long time ago. To edit the commit message you need to select the checkbox next to "Commit Messsage" and press "Edit". This will cause flags to be cleared though.

I can look at ensuring the flags don't get cleared when you do this.

Comment 2 Vijay Bellur 2016-07-23 02:46:40 UTC
(In reply to Nigel Babu from comment #1)
> You still can. Gerrit removed the "Edit Commit Message" button a long time
> ago. To edit the commit message you need to select the checkbox next to
> "Commit Messsage" and press "Edit". This will cause flags to be cleared
> though.
> 

Thanks! I was able to edit the commit message through this process.

> I can look at ensuring the flags don't get cleared when you do this.

This would be great to have.

Comment 3 Nigel Babu 2016-08-02 03:02:52 UTC
The flags already don't get cleared. We used to clear the Verified flag. I've changed it so that you retain them for commit changes and no-change rebases.


Note You need to log in before you can comment on or make changes to this bug.